Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect data returned in frames meta request for a ground truth job #9097

Open
2 tasks done
bsekachev opened this issue Feb 12, 2025 · 2 comments
Open
2 tasks done
Assignees
Labels
bug Something isn't working

Comments

@bsekachev
Copy link
Member

bsekachev commented Feb 12, 2025

Actions before raising this issue

  • I searched the existing issues and did not find anything similar.
  • I read/searched the docs

Steps to Reproduce

  1. Create a task with Ground Truth job, using attached archive (Frame selection method: random).

Content of the image corresponds to the image number in this archive). E.g. this is image_10.jpg. Each image resolution is random. This specific image has resolution 800x900.

Image

  1. Open GT job and check meta response. It has resolution 1500x900. The image distorsed
Image

Of course, image name also may be incorrect:

Image

images.zip

Expected Behavior

No response

Possible Solution

No response

Context

No response

Environment

commit db293b7024ff9252cfb8bb5c648364539d4a6f09
@bsekachev bsekachev added the bug Something isn't working label Feb 12, 2025
@O-J1
Copy link

O-J1 commented Feb 19, 2025

I am observing this issue as well as a paying customer on the cloud service and all of my ground truth images display a name of 'placeholder.jpeg' and most are distorted.

@zhiltsov-max
Copy link
Contributor

The situation is the following:

  1. /api/tasks/<id>/meta returns all the task frames for simple GT jobs (it has always been like this), the excluded frames have dummy information in the "frames" field
  2. For GT jobs in consensus tasks the logic is the same as for regular annotation jobs
  3. There was a function in UI that follows the current logic of the server to obtain correct frame meta
    export function getAllocationTableContents(gtJobMeta: FramesMetaData, gtJob: Job): TableRowData[] {
    . A simplified version can be found here: Fix frame names in the allocation table for simple GT job #8731
  4. Apparently, some recent (since mid December'24) fixes and refactorings in UI missed that difference in the endpoint output. The server API didn't change in this regard and works as before

I'd be great to support both variants of meta output for simple GT jobs. However, it requires changing server API. Specifically, it requires changing the "frames" field to return only frames from the "included_frames" range, if specified. I think we could add a request header or a parameter equivalent to ?return_placeholders=true/false for the /api/tasks/<id>/meta, then and migrate the UI to the updated version and gradually deprecate the old version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants