fix: Ensure that the webpack output filename ends with .js. #73
Conversation
|
I'm not 100% percent sure that this is the correct fix, but it looks good and enables me to view and break into the original source. Let me know what you think. |
jp7677
force-pushed
the
typescript-sourcemaps
branch
from
c801f4a to
66f3d04
Compare
|
Edit: scratch that, was just small mistake on my side. |
There was a problem hiding this comment.
The resolved value of the promise that's returned needs to equal the output path of the file. Since this currently only change's webpack's output and doesn't resolve with the new output path, Cypress won't know where to serve the file from.
If you add a new test that's a copy of this one, but with with a .ts file as the output path, I think you'll see it fail. Please add that test and then update the implementation so that it passes.
|
Thanks a lot for your response. With your comments I’m slowly getting the
full picture, makes totally sense. I guess the bundle cache from previous
runs made it work on my machine ;). I’m not close to my machine for the
next few days, though once I’m, I'll add the changes you suggested.
…On Fri, 10 Apr 2020 at 15:27, Chris Breiding ***@***.***> wrote:
***@***.**** requested changes on this pull request.
The resolved value of the promise that's returned
<https://github.com/cypress-io/cypress-webpack-preprocessor/blob/master/index.js#L152>
needs to equal the output path of the file. Since this currently only
change's webpack's output and doesn't resolve with the new output path,
Cypress won't know where to serve the file from.
If you add a new test that's a copy of this one
<https://github.com/jp7677/cypress-webpack-preprocessor/blob/typescript-sourcemaps/test/unit/index.spec.js#L187>,
but with with a .ts file as the output path, I think you'll see it fail.
Please add that test and then update the implementation so that it passes.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#73 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEDL5XJ6BDK5UZ7MAQNFLMDRL4NEFANCNFSM4MFJH2AQ>
.
|
jp7677
force-pushed
the
typescript-sourcemaps
branch
2 times, most recently
from
9f1ea59 to
ce80c80
Compare
This ensures that the Webpack SourceMapDevToolPlugin can handle the file, even when it has been originally no javascript file (e.g. .ts or .feature).
jp7677
force-pushed
the
typescript-sourcemaps
branch
from
ce80c80 to
10f9eda
Compare
|
@chrisbreiding I've adjusted the PR, let me know if that fits. |
There was a problem hiding this comment.
Thanks a lot, @jp7677. This looks great and is a solid improvement.
chrisbreiding
changed the title
|
🎉 This PR is included in version 5.1.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
…io/cypress-webpack-preprocessor#73) This ensures that the Webpack SourceMapDevToolPlugin can handle the file, even when it has been originally no javascript file (e.g. .ts or .feature). Co-authored-by: Chris Breiding <[email protected]>
This ensures that the Webpack SourceMapDevToolPlugin can handle the file, even when it has been originally no javascript file (e.g. .ts or .feature).
This should fix #68