Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abis.json is not optimized, and we are bundling all the invididual abis as well #463

Open
jellegerbrandy opened this issue May 7, 2020 · 0 comments
Open

abis.json is not optimized, and we are bundling all the invididual abis as well #463

jellegerbrandy opened this issue May 7, 2020 · 0 comments
Assignees
@ben-kaufman

Comments

@jellegerbrandy
Copy link
Contributor

I merged https://github.com/daostack/arc.js/pull/460/files a bit too soon, there are two issues with this release:

  • abis.json is very big (927K), because it duplicates all the JSON files. We should use teh rootVersion optimization when generating the file.
  • we are now bundling BOTH all the invidual ABI files, as well as the abis.json file where all these files are merged in. Of course, dist/lib/abis should only contain the abi.json file.
@jellegerbrandy jellegerbrandy changed the title abis.json is not optimized and we are bundling all the invididual abis as well abis.json is not optimized, and we are bundling all the invididual abis as well May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ben-kaufman ben-kaufman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jellegerbrandy @ben-kaufman