Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update legacy tests to expect TypeError in place of NullThrownError #1595

Closed
nshahan opened this issue Dec 14, 2022 · 0 comments
Closed

Update legacy tests to expect TypeError in place of NullThrownError #1595

nshahan opened this issue Dec 14, 2022 · 0 comments
Assignees
@sgrekhov
Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good

Comments

@nshahan
Copy link

nshahan commented Dec 14, 2022

In Dart 3.0 NullThrownError has been removed and all expectations should be updated to expect a TypeError instead. This expectation is for legacy (pre-null safety) code as well.

These legacy tests need to be updated:

co19_2/Language/Expressions/Throw/evaluation_t04 
co19_2/LibTest/async/Future/Future.sync_A01_t03
co19_2/Utils/tests/Expect/throws_A01_t03

cc @eernstg
@nshahan nshahan added the bad-test Report tests in need of updates. When closed, the tests should be considered good label Dec 14, 2022
@sgrekhov sgrekhov self-assigned this Dec 15, 2022
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Dec 15, 2022
@sgrekhov
Fixes dart-lang#1595. Expect TypeError in place of NullThrownError in…
7a24a9b 
… co19_2 tests
eernstg pushed a commit that referenced this issue Dec 15, 2022
@sgrekhov
Fixes #1595. Expect TypeError in place of NullThrownError in co19_2 t…
f691647 
…ests (#1597)

Authored by @sgrekhov.
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Dec 16, 2022
@sgrekhov
[co19] Roll co19_2 to f691647f1c2cc4f1019fb619932c52d0a1adbf2c
aac2b2e 
2022-12-15 [email protected] Fixes dart-lang/co19#1595. Expect TypeError in place of NullThrownError in co19_2 tests (dart-lang/co19#1597)
2022-12-14 [email protected] dart-lang/co19#1586. Remove CyclicInitializationError from co19_2 tests (dart-lang/co19#1591)
2022-12-13 [email protected] dart-lang/co19#1581. Remove use of Deprecated.expires (dart-lang/co19#1585)

Change-Id: Icbf31546935281067815d59957ed2ddc7e262546
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275921
Commit-Queue: Erik Ernst <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
@athomas athomas mentioned this issue Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nshahan @sgrekhov