Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LanguageFeatures/Constant-update-2018/ShortCircuitOperators_A01_t12 is wrong #492

Closed
athomas opened this issue Oct 9, 2019 · 0 comments
Closed
Assignees

Comments

@athomas
Copy link
Member

athomas commented Oct 9, 2019

stderr:
 tests/co19_2/src/LanguageFeatures/Constant-update-2018/ShortCircuitOperators_A01_t12.dart:23:34: Error: A value of type 'Type' can't be assigned to a variable of type 'bool'.
  - 'Type' is from 'dart:core'.
   const MyClass() : b = false && nil;
                                  ^
const nil = Null;

class MyClass {
  final bool b;
  const MyClass() : b = false && nil;
}

main() {
  const res = MyClass();
}

Maybe const nil = Null;was meant to be const nil = null; (note the lowercase 'N')?

dart-bot pushed a commit to dart-lang/sdk that referenced this issue Oct 9, 2019
From this roll on forward, co19_2 is tracking the pre-nnbd branch rather than the master branch in
the co19 repo. The master branch (the NNBD fork of co19) will be re-introduced as a different suite
later.

Issues reported:
dart-lang/co19#492 (ShortCircuitOperators_A01_t12 test is wrong)
dart-lang/co19#493 (ShortCircuitOperators_A04_t27 has a syntax error)
dart-lang/co19#494 (ShortCircuitOperators_A03_t12 is an invalid test)

2019-10-04 [email protected] Issue 490: useless constant-update-2018 option removed from the tests.
2019-10-04 [email protected] Issue 490: useless constant-update-2018 option removed from the tests.
2019-10-04 [email protected] Fixes 484. Use floating point value which decimal part
2019-10-04 [email protected] Fixes 486. Fix test expectations (method call has higher priority than unary minus)
2019-10-04 [email protected] Fixes 483. Use List instead of Iterable
2019-10-04 [email protected] Issue 485, 488: test expectations corrected.
2019-09-30 [email protected] Issue 477: More tests for constant short circuit operations added.
2019-09-30 [email protected] Issue 477: More tests for constant short circuit operations added.
2019-09-25 [email protected] Issue 481: Test expanded into A Function(Null) instead of A Function(A) by the instantiate-to-bound algorithm.
2019-09-23 [email protected] Issue 477: tests for Constant-2019-update added.
2019-09-19 [email protected] Fixes 480. Use '==' for checking actual type
2019-09-17 [email protected] Issue 477: tests for Constant-2019-update added.
2019-09-17 [email protected] Issue 477: tests for Constant-2019-update added.
2019-09-17 [email protected] NNBD tests removed from this legacy branch
2019-09-16 [email protected] Issue 477: tests for short circuit operators added.
2019-09-13 [email protected] 466. Subtyping tests for NNBD added.
2019-09-12 [email protected] 466. Subtyping tests for NNBDc. Copyright year updated
2019-09-12 [email protected] 466. Subtyping tests for NNBDc. Right Object tests added
2019-09-11 [email protected] 464. Added tests for legacy type fields
2019-09-11 [email protected] Issue 465: tests for Generics in NNBD added.
2019-09-10 [email protected] Issue 465: test for Generics in NNBD added.
2019-09-10 [email protected] 466. Subtyping tests changed according to NNBD spec
2019-09-09 [email protected] 466. Subtyping tests changed according to NNBD spec
2019-09-06 [email protected] Issue 465: tests for Generics in NNBD added.
2019-09-06 [email protected] More tests for type Never
2019-09-05 [email protected] Issue 465: tests for Generics in NNBD added.
2019-09-05 [email protected] Fix using and checking of Never
2019-09-04 [email protected] Fixes 464. Legacy-libraries tests added
2019-09-04 [email protected] Fixed Issue 460: tests for Null promotion added, typos corrected.
2019-09-02 [email protected] Fixes 458. More null-aware operators tests
2019-09-02 [email protected] Fixes 459. Late fields and variables test added
2019-09-02 [email protected] 459. Late fields and variables tests added
2019-08-30 [email protected] 459. Late fields and variables tests added
2019-08-29 [email protected] 459. Late fields and variables tests added
2019-08-29 [email protected] 389. Fixed static warnings processing
2019-08-28 [email protected] 458. Null-aware operators tests added
2019-08-27 [email protected] 458. Null-aware operators tests added
2019-08-27 [email protected] Removed covariant final member
2019-08-27 [email protected] Typo and order of modifiers fixed
2019-08-23 [email protected] 461. A couple of NNBD nested nullable types tests added
2019-08-23 [email protected] 389. NNBD static errors tests. Some tests fixed, several tests added (mainly for legacy libraries)
2019-08-23 [email protected] Fixes 389. A couple of legacy types tests added
2019-08-23 [email protected] Fixes 461.Conditional expression ambiguities tests added
2019-08-23 [email protected] 461. Add nested nullable types tests
2019-08-23 [email protected] Fixes 475. Modifier 'late' must be before 'final'
2019-08-22 [email protected] 389. NNBD static errors tests. Fixed work with legacy libraries and new tests added
2019-08-22 [email protected] 461. NNBD syntax tests added for required and null-aware selector

Change-Id: Icd4d0c536f0091100aa0276ff5b836b16db0ff35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120782
Reviewed-by: William Hesse <[email protected]>
iarkh added a commit that referenced this issue Oct 9, 2019
@iarkh iarkh self-assigned this Oct 9, 2019
iarkh added a commit that referenced this issue Oct 9, 2019
@iarkh iarkh closed this as completed Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants