Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2346. Add expected error in analyzer. Pre-nnbd version #2348

Merged
merged 1 commit into from
Nov 3, 2023
Merged

#2346. Add expected error in analyzer. Pre-nnbd version #2348

merged 1 commit into from
Nov 3, 2023

Conversation

sgrekhov
Copy link
Contributor

@sgrekhov sgrekhov commented Nov 3, 2023

No description provided.

eernstg
eernstg approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit e5b70f6 into dart-lang:pre-nnbd Nov 3, 2023
@sgrekhov sgrekhov deleted the co19_2-2346 branch November 14, 2023 11:30
@athomas athomas mentioned this pull request Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eernstg eernstg eernstg approved these changes

@chloestefantsova chloestefantsova Awaiting requested review from chloestefantsova

@kallentu kallentu Awaiting requested review from kallentu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgrekhov @eernstg