-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2384. Fix not well-bound extension types. Add function-type dynamic test #2387
Conversation
…n-type dynamic test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are a couple of tests whose description doesn't match the contents.
LanguageFeatures/Extension-types/dynamic_semantics_member_invocation_A03_t05.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Extension-types/static_analysis_extension_types_A05_t04.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Extension-types/static_analysis_extension_types_A20_t01.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. Please take another look
LanguageFeatures/Extension-types/dynamic_semantics_member_invocation_A03_t05.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Extension-types/static_analysis_extension_types_A05_t04.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Extension-types/static_analysis_extension_types_A20_t01.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2023-11-23 [email protected] Merge pull request dart-lang/co19#2395 from dart-lang/merge-pre-nnbd 2023-11-23 [email protected] Fixes dart-lang/co19#2390. Fix tests according to the new method/setter rules (dart-lang/co19#2392) 2023-11-23 [email protected] Fixes dart-lang/co19#2388. Add tests for the new method/setter rules. Update assertions (dart-lang/co19#2393) 2023-11-23 [email protected] Merge remote-tracking branch 'origin/pre-nnbd' into master 2023-11-22 [email protected] Fixes dart-lang/co19#2389. Add additional error expectation for analyzer (dart-lang/co19#2391) 2023-11-21 [email protected] dart-lang/co19#2342. Update nullability tests according to the new rules (dart-lang/co19#2385) 2023-11-21 [email protected] Fixes dart-lang/co19#2384. Fix not well-bound extension types. Add function-type dynamic test (dart-lang/co19#2387) Change-Id: Ic3848f6f39fd42b01bfed5feac3d922c6f5a53d5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/338120 Reviewed-by: Erik Ernst <[email protected]> Reviewed-by: Alexander Thomas <[email protected]>
No description provided.