Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3057. Add flow analysis tests for throw expression #3076

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

sgrekhov
Copy link
Contributor

No description provided.

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple of typos.

A slightly deeper thing is that some tests look like they are covering cases that are a bit too deep (if we start doing that consistently then the number of tests will explode).

@sgrekhov
Copy link
Contributor Author

PTAL

@sgrekhov sgrekhov requested a review from eernstg February 17, 2025 10:15
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eernstg eernstg merged commit 7462554 into dart-lang:master Feb 17, 2025
2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Feb 24, 2025
2025-02-20 [email protected] Fixes dart-lang/co19#3084. Update expected errors positions in member_definition_t10.dart (dart-lang/co19#3085)
2025-02-19 [email protected] dart-lang/co19#3057. Add tests for logical and, or and null-check operators (dart-lang/co19#3082)
2025-02-19 [email protected] dart-lang/co19#3057. Add more null-check tests (dart-lang/co19#3081)
2025-02-17 [email protected] dart-lang/co19#3057. Update operator `==` tests updated and add new ones (dart-lang/co19#3077)
2025-02-17 [email protected] dart-lang/co19#3057. Add instance check tests (dart-lang/co19#3078)
2025-02-17 [email protected] dart-lang/co19#3057. Add flow analysis tests for throw expression (dart-lang/co19#3076)
2025-02-17 [email protected] dart-lang/co19#3057. Add more flow analysis tests for type Never. Part 2. (dart-lang/co19#3071)
2025-02-17 [email protected] Fixes dart-lang/co19#3079. Fix numerous typos in Parts with imports tests (dart-lang/co19#3080)
2025-02-17 [email protected] dart-lang/co19#3057. Add more flow analysis tests for type Never (dart-lang/co19#3070)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: I3d4450e3687fe542737b397aa097d56211534c9b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411240
Reviewed-by: Alexander Thomas <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
Commit-Queue: Alexander Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants