-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3057. Add more null-check tests #3081
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think a couple of tests could be made a bit stronger by eliminating a false positive when the status is "don't know".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Updated except reachability_A15_t03.dart
. PTAL.
Typo in description
Typo in description
Typo in description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
(Fixed a couple of typos in descriptions.)
2025-02-20 [email protected] Fixes dart-lang/co19#3084. Update expected errors positions in member_definition_t10.dart (dart-lang/co19#3085) 2025-02-19 [email protected] dart-lang/co19#3057. Add tests for logical and, or and null-check operators (dart-lang/co19#3082) 2025-02-19 [email protected] dart-lang/co19#3057. Add more null-check tests (dart-lang/co19#3081) 2025-02-17 [email protected] dart-lang/co19#3057. Update operator `==` tests updated and add new ones (dart-lang/co19#3077) 2025-02-17 [email protected] dart-lang/co19#3057. Add instance check tests (dart-lang/co19#3078) 2025-02-17 [email protected] dart-lang/co19#3057. Add flow analysis tests for throw expression (dart-lang/co19#3076) 2025-02-17 [email protected] dart-lang/co19#3057. Add more flow analysis tests for type Never. Part 2. (dart-lang/co19#3071) 2025-02-17 [email protected] Fixes dart-lang/co19#3079. Fix numerous typos in Parts with imports tests (dart-lang/co19#3080) 2025-02-17 [email protected] dart-lang/co19#3057. Add more flow analysis tests for type Never (dart-lang/co19#3070) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try Change-Id: I3d4450e3687fe542737b397aa097d56211534c9b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411240 Reviewed-by: Alexander Thomas <[email protected]> Reviewed-by: Erik Ernst <[email protected]> Commit-Queue: Alexander Thomas <[email protected]>
No description provided.