-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pub_semver] Remove dependency on package:meta
#2021
base: main
Are you sure you want to change the base?
Conversation
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind this - but I'm also not sure we need to do it. A dependency on package:meta is quite benign, and I don't see the advantage we get from the potential breakage.
Similar discussions in dart-lang/core#859
cc @lrhn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not breaking in the SemVer sense to disallow something that is clearly documented as not allowed.
SemVer is an API stability promise, and if extending or implementing is marked as not part of the promised API, it's not a SemVer issue if that changes behavior.
Fair, that is a good point! |
Use the
final
class modifier onVersion
instead of@sealed
. This could technically break anyone who overrides the class while ignoring the resulting diagnostic from@sealed
.