Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

Migration darwinia-staking to Attribute Macro #924

Merged
merged 10 commits into from
Nov 15, 2021
Merged

Conversation

aurexav
Copy link
Member

@aurexav aurexav commented Nov 11, 2021

Close #864.

@aurexav aurexav requested a review from hackfisher as a code owner November 11, 2021 15:31
@aurexav aurexav marked this pull request as draft November 11, 2021 15:31
@aurexav aurexav mentioned this pull request Nov 11, 2021
14 tasks
@aurexav aurexav marked this pull request as ready for review November 13, 2021 15:38
@aurexav aurexav marked this pull request as draft November 13, 2021 18:15
@aurexav aurexav added the BK-Storage [Break] This changes storage; next release should be major. label Nov 14, 2021
@aurexav aurexav marked this pull request as ready for review November 14, 2021 12:58
@github-actions
Copy link

github-actions bot commented Nov 14, 2021

Commit 9a95546

Pangolin

Check Runtime Version

Check Storage Prefix

- Pallet: "DarwiniaStaking"

Pallet ElectionProviderMultiPhase:
+ 	Item: Storage { name: "SignedSubmissionIndices", type: Plain("SubmissionIndicesOf<T>") }
+ 	Item: Storage { name: "SignedSubmissionNextIndex", type: Plain("u32") }
+ 	Item: Storage { name: "SignedSubmissionsMap", type: Map { hasher: Twox64Concat, key: "u32", value: "SignedSubmissionOf<T>", unused: false } }

+ Pallet: "Staking"​

Pangoro

Check Runtime Version

Check Storage Prefix

- Pallet: "DarwiniaStaking"

Pallet ElectionProviderMultiPhase:
+ 	Item: Storage { name: "SignedSubmissionIndices", type: Plain("SubmissionIndicesOf<T>") }
+ 	Item: Storage { name: "SignedSubmissionNextIndex", type: Plain("u32") }
+ 	Item: Storage { name: "SignedSubmissionsMap", type: Map { hasher: Twox64Concat, key: "u32", value: "SignedSubmissionOf<T>", unused: false } }

+ Pallet: "Staking"​
Commit 38a8ec4

Pangolin

Check Runtime Version

Check Storage Prefix

- Pallet: "DarwiniaStaking"

Pallet ElectionProviderMultiPhase:
+ 	Item: Storage { name: "SignedSubmissionIndices", type: Plain("SubmissionIndicesOf<T>") }
+ 	Item: Storage { name: "SignedSubmissionNextIndex", type: Plain("u32") }
+ 	Item: Storage { name: "SignedSubmissionsMap", type: Map { hasher: Twox64Concat, key: "u32", value: "SignedSubmissionOf<T>", unused: false } }

+ Pallet: "Staking"​

Pangoro

Check Runtime Version

Check Storage Prefix

- Pallet: "DarwiniaStaking"

Pallet ElectionProviderMultiPhase:
+ 	Item: Storage { name: "SignedSubmissionIndices", type: Plain("SubmissionIndicesOf<T>") }
+ 	Item: Storage { name: "SignedSubmissionNextIndex", type: Plain("u32") }
+ 	Item: Storage { name: "SignedSubmissionsMap", type: Map { hasher: Twox64Concat, key: "u32", value: "SignedSubmissionOf<T>", unused: false } }

+ Pallet: "Staking"​
Commit d29c779

Pangolin

Check Runtime Version

Check Storage Prefix

- Pallet: "DarwiniaStaking"

Pallet ElectionProviderMultiPhase:
+ 	Item: Storage { name: "SignedSubmissionIndices", type: Plain("SubmissionIndicesOf<T>") }
+ 	Item: Storage { name: "SignedSubmissionNextIndex", type: Plain("u32") }
+ 	Item: Storage { name: "SignedSubmissionsMap", type: Map { hasher: Twox64Concat, key: "u32", value: "SignedSubmissionOf<T>", unused: false } }

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
+ 	Item: Storage { name: "CollateralSlashProtect", type: Plain("RingBalance<T>") }
+ 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, RingBalance<T>>", unused: false } }
- 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, Fee<T>>", unused: false } }

+ Pallet: "Staking"​

Pangoro

Check Runtime Version

Check Storage Prefix

- Pallet: "DarwiniaStaking"

Pallet ElectionProviderMultiPhase:
+ 	Item: Storage { name: "SignedSubmissionIndices", type: Plain("SubmissionIndicesOf<T>") }
+ 	Item: Storage { name: "SignedSubmissionNextIndex", type: Plain("u32") }
+ 	Item: Storage { name: "SignedSubmissionsMap", type: Map { hasher: Twox64Concat, key: "u32", value: "SignedSubmissionOf<T>", unused: false } }

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
+ 	Item: Storage { name: "CollateralSlashProtect", type: Plain("RingBalance<T>") }
+ 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, RingBalance<T>>", unused: false } }
- 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, Fee<T>>", unused: false } }

+ Pallet: "Staking"​

Copy link
Contributor

@hackfisher hackfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @AurevoirXavier there are some conflicts need to be resolved.

@hackfisher hackfisher merged commit 2d2dc2a into master Nov 15, 2021
@hackfisher hackfisher deleted the xavier-staking branch November 15, 2021 06:37
@aurexav aurexav added the C-Substrate [Component] Something about Substrate label Nov 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
BK-Storage [Break] This changes storage; next release should be major. C-Substrate [Component] Something about Substrate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Staking to Attribute Macro
2 participants