Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staking Substrate Tests #351

Merged
merged 82 commits into from
Mar 21, 2020
Merged

Staking Substrate Tests #351

merged 82 commits into from
Mar 21, 2020

Conversation

aurexav
Copy link
Member

@aurexav aurexav commented Mar 16, 2020

No description provided.

aurexav and others added 23 commits March 12, 2020 21:53
@aurexav aurexav mentioned this pull request Mar 16, 2020
Merged
aurexav added 5 commits March 18, 2020 19:55
@aurexav
Merge remote-tracking branch 'upstream/develop' into staking-tests
d21098d 
# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	bin/node/cli/Cargo.toml
#	bin/node/executor/Cargo.toml
#	bin/node/runtime/Cargo.toml
#	bin/node/testing/Cargo.toml
#	frame/chainrelay/eth/backing/Cargo.toml
#	frame/claims/src/lib.rs
#	frame/staking/CHANGELOG.md
#	frame/staking/Cargo.toml
#	frame/staking/README.md
#	frame/staking/src/lib.rs
#	frame/staking/src/mock.rs
#	frame/vesting/src/lib.rs
@aurexav
add: substrate tests
c19ee84
@aurexav
fix: basic_setup_works
d8a9910
@aurexav
fix: change_controller_works
ffa5482
@aurexav
fix: #340
9b446e1
@aurexav aurexav linked an issue Mar 20, 2020 that may be closed by this pull request
is_zero Logic in Slashing #375
Closed
@aurexav
Copy link
Member Author

aurexav commented Mar 20, 2020 •
edited
Loading

All substrate tests passed!

Thus the phragmen hack, slash hack, lazy payout hack work as expected!

There're 78 commits in this PR.

I'll finish the darwinia tests in next PR.

@aurexav aurexav requested a review from hackfisher March 20, 2020 15:22
hackfisher
hackfisher requested changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@hackfisher hackfisher left a comment •
edited by aurexav
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the extra pallets added from substrate, and the substrate dep version.

Sry. This pr was base on lazy payout. I’ll make a merge.

@aurexav aurexav merged commit 6f08993 into darwinia-network:develop Mar 21, 2020
@aurexav aurexav deleted the staking-tests branch March 21, 2020 09:05
This was referenced Mar 23, 2020
Merged
Merged
@aurexav aurexav linked an issue Mar 24, 2020 that may be closed by this pull request
Storage Clean #345
Closed
boundless-forest added a commit that referenced this pull request Aug 1, 2023
@boundless-forest
Remove useless param (#351)
4ccdaa0 
* Remove useless client param

* Update version

* Make compile happly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hackfisher hackfisher hackfisher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@aurexav @hackfisher @clearloop