Let ProcessPendingReconstructedRecoveredSigs return void instead of bool

Return value is unused and the method actually never returned something.
dashpay · Mar 7, 2019 · fae33e0 · fae33e0
1 parent f8f867a
commit fae33e0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/llmq/quorums_signing.cpp b/src/llmq/quorums_signing.cpp
@@ -440,7 +440,7 @@ void CSigningManager::CollectPendingRecoveredSigsToVerify(
     }
 }
 
-bool CSigningManager::ProcessPendingReconstructedRecoveredSigs()
+void CSigningManager::ProcessPendingReconstructedRecoveredSigs()
 {
     decltype(pendingReconstructedRecoveredSigs) l;
     {

diff --git a/src/llmq/quorums_signing.h b/src/llmq/quorums_signing.h
@@ -154,7 +154,7 @@ class CSigningManager
     void CollectPendingRecoveredSigsToVerify(size_t maxUniqueSessions,
             std::unordered_map<NodeId, std::list<CRecoveredSig>>& retSigShares,
             std::unordered_map<std::pair<Consensus::LLMQType, uint256>, CQuorumCPtr, StaticSaltedHasher>& retQuorums);
-    bool ProcessPendingReconstructedRecoveredSigs();
+    void ProcessPendingReconstructedRecoveredSigs();
     bool ProcessPendingRecoveredSigs(CConnman& connman); // called from the worker thread of CSigSharesManager
     void ProcessRecoveredSig(NodeId nodeId, const CRecoveredSig& recoveredSig, const CQuorumCPtr& quorum, CConnman& connman);
     void Cleanup(); // called from the worker thread of CSigSharesManager
-Original file line number
+Diff line change
@@ Expand Up / @@ -440,7 +440,7 @@ void CSigningManager::CollectPendingRecoveredSigsToVerify( @@
         }
     }
-    bool CSigningManager::ProcessPendingReconstructedRecoveredSigs()
+    void CSigningManager::ProcessPendingReconstructedRecoveredSigs()
     {
         decltype(pendingReconstructedRecoveredSigs) l;
         {
@@ Expand Down @@