Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade rust-toolchain to nightly-2022-09-02 #7466

Closed
drmingdrmer opened this issue Sep 3, 2022 · 6 comments · Fixed by #7741
Closed

Upgrade rust-toolchain to nightly-2022-09-02 #7466

drmingdrmer opened this issue Sep 3, 2022 · 6 comments · Fixed by #7741
Labels
C-improvement Category: improvement dependencies Pull requests that update a dependency file

Comments

@drmingdrmer
Copy link
Member

rust-1.63 is released, and the new nightly(2022-09-02) introduces different APIs:

  • std::Error::backtrace() is replaced with provider style API: request_ref::<Backtrace>().
  • std::Simd API changes that affect arrow2: a draft update is fired for illustration.

The changes about Error affect several third-party crates too, such as thiserror, in 1.0.33 it switched to the provider style API to retrieve backtrace.

openraft is updated and is ready to upgrade to nightly-2022-09-02.

Once these modifications are ready, it's time to upgrade to the new nightly 2022-09-02.

@sundy-li @Xuanwo @PsiACE
Opinion? Suggestions? 🤔
@drmingdrmer drmingdrmer added C-improvement Category: improvement dependencies Pull requests that update a dependency file labels Sep 3, 2022
@Xuanwo
Copy link
Member

Xuanwo commented Sep 4, 2022

I tried this a couple of days ago, which was blocked by databendlabs/openraft#546

It LGTM to upgrade nightly-2022-09-02 now!

This was referenced Sep 9, 2022
Closed
Merged
@xudong963
Copy link
Member

Any update?

@Xuanwo
Copy link
Member

Xuanwo commented Sep 19, 2022

I will work on thid issue later this week. And it also open to be taken by anyone interested~

@xudong963
Copy link
Member

I'm solving the issue @Xuanwo

@Xuanwo
Copy link
Member

Xuanwo commented Sep 19, 2022

I'm solving the issue @Xuanwo

Great!

@Xuanwo
Copy link
Member

Xuanwo commented Sep 19, 2022

Here are some links that may be helpful to you: https://databend.rs/doc/faq/routine-maintenance

@xudong963 xudong963 mentioned this issue Sep 20, 2022
Merged
@mergify mergify bot closed this as completed in #7741 Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-improvement Category: improvement dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: upgrade rust-toolchain to nightly-2022-09-18 xudong963/databend
3 participants
@drmingdrmer @Xuanwo @xudong963