Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbt-external-tables is incompatible with dbt v0.18 #39

Closed
vogt4nick opened this issue Sep 3, 2020 · 2 comments
Closed

dbt-external-tables is incompatible with dbt v0.18 #39

vogt4nick opened this issue Sep 3, 2020 · 2 comments

Comments

@vogt4nick
Copy link

I propose a change to require only dbt-utils >=0.4.0. Currently dbt-external-tables requires dbt-utils >=0.4.0, <0.6.0.

https://github.com/fishtown-analytics/dbt-external-tables/blob/3f094ff90af11ea5e671fcdc696e6c8c4097aa54/packages.yml#L1-L3

It'd be useful to use dbt-external-tables with dbt v0.18 and dbt-utils v0.6, but the transitive requirements on dbt-utils make dbt-external-tables incompatible with dbt v0.18. AFAICT, dbt-external-tables does not need to enforce the v0.6 requirement on dbt-utils.

I may be totally wrong about this; I don't know much about the inner workings about dbt myself. I'll make a PR, but I'm hoping to get some feedback from a project owner to help me verify that dbt-external-tables is not affected by the breaking changes introduced in dbt v0.18 or dbt-utils v0.6.

Resources

@jtcohen6
Copy link
Collaborator

jtcohen6 commented Sep 3, 2020

Right on, @vogt4nick! This is on our to-do list :) I think we'll be able to just bump the utils requirement to

     version: [">=0.4.0", "<0.7.0"] 

@vogt4nick
Copy link
Author

Wonderful! I'll hold out for that change to dbt-utils and close this issue then 😄 Thanks for the fast response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants