Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Metric names aren't run through name regex #181

Closed
1 task done
Tracked by #191
QMalcolm opened this issue Oct 16, 2023 · 0 comments · Fixed by #184
Closed
1 task done
Tracked by #191

[Bug] Metric names aren't run through name regex #181

QMalcolm opened this issue Oct 16, 2023 · 0 comments · Fixed by #184
Assignees
@QMalcolm
Labels
bug Something isn't working

Comments

@QMalcolm
Copy link
Collaborator

Housekeeping

  • I am a maintainer of dbt-semantic-interfaces

Short description

Metric names aren't run through the valid name regex in UniqueAndValidNameRule even though the rule documents that it is.

Acceptance criteria

Metric names are validated against the valid name regex

Impact to Other Teams

core

Will backports be required?

0.3.latest

Context

No response
@QMalcolm QMalcolm added bug Something isn't working Backport 0.3.latest Fix should be backported to 0.3.latest labels Oct 16, 2023
@QMalcolm QMalcolm self-assigned this Oct 17, 2023
This was referenced Oct 23, 2023
Merged
Closed
@QMalcolm QMalcolm removed the Backport 0.3.latest Fix should be backported to 0.3.latest label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@QMalcolm QMalcolm

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Begin Validating Metric Names dbt-labs/dbt-semantic-interfaces
1 participant
@QMalcolm