Rename objects lib to implementations
#43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callum-mcdata
approved these changes
May 17, 2023
QMalcolm
force-pushed
the
qmalcolm--rename-objects-implementations
branch
from
5500009 to
080663c
Compare
We called these things objects before because they were The Objects(TM). However, now these objects are just default/example implementations of the protocols. We've even begun referring to them as "implementations". As such, it seemed time to rename them accordingly.
QMalcolm
force-pushed
the
qmalcolm--rename-objects-implementations
branch
from
080663c to
34fdce2
Compare
|
I'm gonna move forward and consider @callum-mcdata's approval still valid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We called these things objects before because they were The Objects(TM).
However, now these objects are just default/example implementations of
the protocols. We've even begun referring to them as "implementations".
As such, it seemed time to rename them accordingly.
Checklist
changie newto create a changelog entry