You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm totally 100% behind this change, but there needs to be some cleaning up here to communicate it.
The README.md still says shows an example of passing a hardcoded table reference in the pivot example
Techhhhhnically we should replace the table argument name with relation, but that's likely going to break things (on the fence about whether we should fix it)
There's also a little bit of redundant code in get_column_values which would be good to clean up:
{%- set target_relation = adapter.get_relation(database=table.database,
schema=table.schema,
identifier=table.identifier) -%}
can be replaced with
{%- set target_relation = table -%}
The text was updated successfully, but these errors were encountered:
Steps to reproduce
get_column_values
with a string table referenceExpected results
Actual results
Commentary
Prior to v0.2.1, you could pass
get_column_values
a table like thismy_schema.my_table
.However #152 now means you need to pass the macro a
relation
instead. All of these are valid:I'm totally 100% behind this change, but there needs to be some cleaning up here to communicate it.
table
argument name withrelation
, but that's likely going to break things (on the fence about whether we should fix it)get_column_values
which would be good to clean up:can be replaced with
The text was updated successfully, but these errors were encountered: