You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Mintable authentication (owner and minters) was removed from the PoC until it found a new place to be, #29 unlocks that, we should make an MintLib or something that could implement msg_sender validation for minting (when externally called).
TokenLib internal minting should always be at dispose for the developer, that could TokenLib::mint_to_private at constructor. Mintable trait (and authentication) shouldn't be needed for a dev to fully develop over a token that doesn't require the Mintable interface.
Developer is in charge of implementing the authentication pattern (we provide a PoC with owner and minters array), and the MintLib methods should provide enough information to authenticate the mint. These method names are gonna be reused across different authentication schemes, as the injected "Token code" will optimistically call MintLib::validate_mint (ignoring which MintLib is being imported in the top layer contract).
MintLib is also responsible of defining (at comptime) which storage struct items are required, this is specific for each MintLib implementations, but internal calls (called from injected Token) should be commonly named and populated for all.
The text was updated successfully, but these errors were encountered:
Mintable authentication (
owner
andminters
) was removed from the PoC until it found a new place to be, #29 unlocks that, we should make an MintLib or something that could implementmsg_sender
validation for minting (when externally called).TokenLib internal minting should always be at dispose for the developer, that could
TokenLib::mint_to_private
at constructor. Mintable trait (and authentication) shouldn't be needed for a dev to fully develop over a token that doesn't require the Mintable interface.Developer is in charge of implementing the authentication pattern (we provide a PoC with owner and minters array), and the MintLib methods should provide enough information to authenticate the mint. These method names are gonna be reused across different authentication schemes, as the injected "Token code" will optimistically call
MintLib::validate_mint
(ignoring whichMintLib
is being imported in the top layer contract).MintLib is also responsible of defining (at comptime) which storage struct items are required, this is specific for each MintLib implementations, but internal calls (called from injected Token) should be commonly named and populated for all.
The text was updated successfully, but these errors were encountered: