Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Google Threat Intelligence] Private url scanning #38457

Merged
merged 11 commits into from
Feb 12, 2025
Merged

[Google Threat Intelligence] Private url scanning #38457

merged 11 commits into from
Feb 12, 2025

Conversation

pabloperezj
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

@CLAassistant
Copy link

CLAassistant commented Feb 3, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack labels Feb 3, 2025
@content-bot content-bot changed the base branch from master to contrib/VirusTotal_feat/gti-private-url-scanning February 3, 2025 09:55
@content-bot content-bot requested a review from talzich February 3, 2025 09:56
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @talzich will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @pabloperezj, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

@content-bot content-bot added Partner-Approved Contribution Form Filled Whether contribution form filled or not. Partner labels Feb 3, 2025
talzich
talzich requested changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@talzich talzich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pabloperezj, and thank you for your contribution!
To move forward with our review the CLA needs to be signed 😃

@pabloperezj
Copy link
Contributor Author

Hi @pabloperezj, and thank you for your contribution! To move forward with our review the CLA needs to be signed 😃

Done. Thanks! @talzich

@pabloperezj pabloperezj requested a review from talzich February 6, 2025 09:22
@talzich talzich requested a review from MLainer1 February 10, 2025 08:45
talzich
talzich requested changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@talzich talzich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pabloperezj, I've reviewed your contribution and overall things look great!
A few comments to make it perfect :)

Also, notice the pre-commit failure and let me know if you need any help resolving that.

Cheers,
Tal

Packs/GoogleThreatIntelligence/Integrations/GoogleThreatIntelligence/test_data/private_url.json Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the data in that file (urls, ids, twitter handles etc.) OK for publish?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is OK!

@pabloperezj
Copy link
Contributor Author

Hi @pabloperezj, I've reviewed your contribution and overall things look great! A few comments to make it perfect :)

Also, notice the pre-commit failure and let me know if you need any help resolving that.

Cheers, Tal

Hi @talzich, thank you for your review :)

I had some problems with the pre-commit, it would be great if you could help me :)

@talzich
Copy link
Contributor

talzich commented Feb 10, 2025

Hi @pabloperezj, I've reviewed your contribution and overall things look great! A few comments to make it perfect :)
Also, notice the pre-commit failure and let me know if you need any help resolving that.
Cheers, Tal

Hi @talzich, thank you for your review :)

I had some problems with the pre-commit, it would be great if you could help me :)

Sure! Sent you some instructions and examples via Slack

@talzich talzich added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Feb 11, 2025
@content-bot
Copy link
Collaborator

For the Reviewer: Trigger build request has been accepted for this contribution PR.

@content-bot
Copy link
Collaborator

For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/2425571

@content-bot content-bot removed the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Feb 11, 2025
@talzich talzich merged commit f4259b2 into demisto:contrib/VirusTotal_feat/gti-private-url-scanning Feb 12, 2025
19 of 20 checks passed
@content-bot content-bot mentioned this pull request Feb 12, 2025
Merged
5 tasks
@github-actions GitHub Actions
Copy link

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

talzich pushed a commit that referenced this pull request Feb 12, 2025
@content-bot @pabloperezj
[Google Threat Intelligence] Private url scanning (#38457) (#38612)
108c951 
* feat(GTI): Private URL scanning

* Add tests

* Add tests

* Update yml

* Generate docs

* Update release note

* Fix

* Fix pre-commit

* Update docker image

* Fix

* Fix

Co-authored-by: Pablo Pérez <[email protected]>
@pabloperezj pabloperezj mentioned this pull request Feb 24, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talzich talzich talzich approved these changes

@MLainer1 MLainer1 Awaiting requested review from MLainer1

@samuelFain samuelFain Awaiting requested review from samuelFain

@YuvHayun YuvHayun Awaiting requested review from YuvHayun

Assignees

@talzich talzich

@edik24 edik24

Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pabloperezj @CLAassistant @content-bot @talzich @edik24