Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: KafkaV3 Schema Registry and AVRO support #38784

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Contributor

@jesusgpo

Contributing to Cortex XSOAR Content

Status

Waiting for the new imagen vendors-sdk with confluent-kafka extra avro: demisto/dockerfiles#35932

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Description

  • Add Schema Registry support
  • Add publish-msg AVRO support
  • Refactor default partition management in publish-msg
  • Fix trust_any_cert bad management

* feat: add Schema Registry support

* refactor: publish-msg default partition 0

* feat: publish-msg avro support

* fix: bad trust_any_cert management

* docs: add contributors file

* refactor: automatic code format

* refactor: raise exception schema registry none exception in produce-msg

* refactor: fix Mypy errors

* recator: format, lines too long

* refactor: remove redundant else after return

* test: add KSchemaRegistryClient mocks

* chore: update docker image

* refactor: kafka_schema_registry_client validation before schema

* test: mock KSchemaRegistryClient

* test: sasl remove bad validation

* test: add produce error tests

* refactor: SIM118 Use key not in dict instead of key not in dict.keys()

* test: add produce avro tests

* docs: add release notes

* style: automatic format

* style: add params definition

* fix: add required sectionorder in yml

* Update Packs/Kafka/ReleaseNotes/2_1_0.md

Co-authored-by: ShirleyDenkberg <[email protected]>

* Update playbook-Kafka_test.yml

* Update Packs/Kafka/Integrations/KafkaV3/KafkaV3.yml

Co-authored-by: inbalapt1 <[email protected]>

* Update Packs/Kafka/Integrations/KafkaV3/KafkaV3.yml

Co-authored-by: inbalapt1 <[email protected]>

* Update Packs/Kafka/Integrations/KafkaV3/KafkaV3.py

Co-authored-by: inbalapt1 <[email protected]>

* refactor: debug logs reorganization

* refactor: avoid value_schema_type None check

* refactor: improve partition logic in produce msg

* refactor: add logger to KSchemaRegistryClient

* refactor: validate_params improvements

* refactor: publish partition arg manage improvements

* refactor: trust any cert logic

* refactor: update tests

* refactor: format

* refactor: format

* remove logging

* update readme

* update rn

* fix: update SASL logic

* fix: partition improvements

* docs: update releases notes

* fix rn

---------

Co-authored-by: ShirleyDenkberg <[email protected]>
Co-authored-by: inbalapt1 <[email protected]>
Co-authored-by: [email protected] <[email protected]>
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! docs-approved Contribution Form Filled Whether contribution form filled or not. Community Xsoar Support Level Indicates that the contribution is for XSOAR supported pack Internal PR labels Feb 26, 2025
Copy link

github-actions bot commented Feb 26, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/Kafka/Integrations/KafkaV3
   KafkaV3.py4547383%86, 101, 108, 111–112, 114, 164, 180, 185, 190, 206, 227–231, 241–242, 246–252, 255, 260, 262–263, 341, 398, 422–426, 428, 431–432, 443, 446–447, 520–527, 529–536, 538, 540–545, 548–549, 551, 629, 632–633, 685, 712
TOTAL4547383% 

Tests Skipped Failures Errors Time
78 0 💤 0 ❌ 0 🔥 3.533s ⏱️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved Internal PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants