Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get mapping fields function does not except any arguments #38786

Draft
wants to merge 2 commits into
base: contrib/bryanster_patch-sentinelonev2
Choose a base branch
from

Conversation

bryanster
Copy link

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

this simple bug fix makes it possible to update the outgoing mapper.
currently the mapper edit view does not show fields due to all commands getting arguments while 0 where expected:
def get_mapping_fields_command():

Must have

  • Tests
  • Documentation

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack labels Feb 26, 2025
@content-bot content-bot changed the base branch from master to contrib/bryanster_patch-sentinelonev2 February 26, 2025 22:10
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @inbalapt1 will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @bryanster, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

@bryanster
Copy link
Author

bryanster commented Feb 26, 2025

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

when opening the link it shows "SAP" is that correct? see screenshot below
Could it be that cla-assistant is not configured correctly?
because in my understand the cla should be the same as the pdf found here
image
@inbalapt1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants