Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBMS-66936: Self-Service: PMC: Supporting files: Encryption Files Updates #32768

Conversation

adam-antonioli
Copy link
Contributor

@adam-antonioli adam-antonioli commented Oct 29, 2024

Jira Link: MBMS-66936

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

As a Veteran and/or family member, I need the Supporting documents section to provide clear guidance on what is NOT accepted so that I am aware of the necessary materials needed to provide to get a quick determination on possible eligibility.

Testing done

  • Local testing

Screenshots

⚙️TEST DATA ONLY

Screen.Recording.2024-10-29.at.10.53.08.mov

⚙️TEST DATA ONLY

Screen.Recording.2024-10-29.at.10.56.51.mov

What areas of the site does it impact?

PMC form 40-0247

Acceptance criteria

Screenshot 2024-10-30 at 09 39 02 Screenshot 2024-10-30 at 09 39 36

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

@va-vfs-bot va-vfs-bot temporarily deployed to master/MBMS-66936-Self-Service-PMC-Supporting-files-Encryption-Files-Updates/main October 29, 2024 14:56 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MBMS-66936-Self-Service-PMC-Supporting-files-Encryption-Files-Updates/main October 29, 2024 15:14 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MBMS-66936-Self-Service-PMC-Supporting-files-Encryption-Files-Updates/main October 29, 2024 16:05 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MBMS-66936-Self-Service-PMC-Supporting-files-Encryption-Files-Updates/main October 30, 2024 13:15 Inactive
@adam-antonioli adam-antonioli changed the title MBMS-66936 copy pre-need FileField design to PMC form MBMS-66936: Self-Service: PMC: Supporting files: Encryption Files Updates Oct 30, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to master/MBMS-66936-Self-Service-PMC-Supporting-files-Encryption-Files-Updates/main October 30, 2024 13:27 Inactive
ksantiagoBAH
ksantiagoBAH previously approved these changes Oct 30, 2024
@ksantiagoBAH ksantiagoBAH self-requested a review October 30, 2024 14:45
@va-vfs-bot va-vfs-bot temporarily deployed to master/MBMS-66936-Self-Service-PMC-Supporting-files-Encryption-Files-Updates/main October 30, 2024 15:25 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MBMS-66936-Self-Service-PMC-Supporting-files-Encryption-Files-Updates/main October 30, 2024 19:14 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MBMS-66936-Self-Service-PMC-Supporting-files-Encryption-Files-Updates/main October 31, 2024 15:00 Inactive
@adam-antonioli adam-antonioli marked this pull request as ready for review October 31, 2024 15:22
@adam-antonioli adam-antonioli requested review from a team as code owners October 31, 2024 15:22
Copy link

@va-vfs-bot va-vfs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

);
})}
</ul>
)}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint disabled here

@adam-antonioli adam-antonioli merged commit efa8513 into main Oct 31, 2024
82 of 85 checks passed
@adam-antonioli adam-antonioli deleted the MBMS-66936-Self-Service-PMC-Supporting-files-Encryption-Files-Updates branch October 31, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants