Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes test based on order change on detail pages from NCA change #34941

Merged
merged 3 commits into from
Feb 27, 2025
+1 −1
Merged

Fixes test based on order change on detail pages from NCA change #34941

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00a308d
order change on detail pages
eselkin Feb 26, 2025
e3e5c07
Merge branch 'main' into fix-test-facilities-prog-disclosure-details-…
powellkerry Feb 26, 2025
6b210c7
Merge branch 'main' into fix-test-facilities-prog-disclosure-details-…
powellkerry Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/applications/facility-locator/tests/e2e/facilitySearchProgDisc.cypress.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@
cy.get('#other-tools').should('exist');
});

it.skip('should render breadcrumbs ', () => {

Check warning on line 121 in src/applications/facility-locator/tests/e2e/facilitySearchProgDisc.cypress.spec.js

View workflow job for this annotation

GitHub Actions / Skipped e2e Annotations

src/applications/facility-locator/tests/e2e/facilitySearchProgDisc.cypress.spec.js#L121 

Skipped e2e test found.
cy.visit('/find-locations');
typeInCityStateInput('Austin, TX');
selectFacilityTypeInDropdown(FACILITY_TYPES.HEALTH);
Expand All @@ -127,7 +127,7 @@
cy.axeCheck();

cy.get('.facility-result va-link').should('exist');
cy.findByText(/Washington VA Medical Center/i, { selector: 'va-link' })

Check warning on line 130 in src/applications/facility-locator/tests/e2e/facilitySearchProgDisc.cypress.spec.js

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/facility-locator/tests/e2e/facilitySearchProgDisc.cypress.spec.js:130:7:It is unsafe to chain further commands that rely on the subject after this command. It is best to split the chain, chaining again from `cy.` in a next command line.
.first()
.click({ waitForAnimations: true })
.then(() => {
Expand Down Expand Up @@ -165,7 +165,7 @@
});
});

it('shows search result header even when no results are found', () => {

Check warning on line 168 in src/applications/facility-locator/tests/e2e/facilitySearchProgDisc.cypress.spec.js

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/facility-locator/tests/e2e/facilitySearchProgDisc.cypress.spec.js:168:3:Cypress E2E tests must include at least one axeCheck call. Documentation for adding checks and understanding errors can be found here: https://depo-platform-documentation.scrollhelp.site/developer-docs/A11y-Testing.1935409178.html
cy.visit('/find-locations');
// override so no provider data
CcpHelpers.initApplicationMock('', 'mockProviders');
Expand All @@ -178,7 +178,7 @@
cy.get('#facility-search').click({ waitForAnimations: true });
cy.wait('@mockProviders');

cy.focused().contains(

Check warning on line 181 in src/applications/facility-locator/tests/e2e/facilitySearchProgDisc.cypress.spec.js

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/facility-locator/tests/e2e/facilitySearchProgDisc.cypress.spec.js:181:5:It is unsafe to chain further commands that rely on the subject after this command. It is best to split the chain, chaining again from `cy.` in a next command line.
'No results found for "Community providers (in VA’s network)", "General Acute Care Hospital" near "Raleigh, North Carolina 27606"',
);
cy.get('#other-tools').should('exist');
Expand Down Expand Up @@ -220,7 +220,7 @@
.should('exist');
cy.get('.facility-phone-group').should('exist');
cy.get('va-link')
.eq(1)
.eq(0)
.shadow()
.get('a')
.contains(/Get directions/i);
Expand All @@ -231,7 +231,7 @@
cy.axeCheck();
});

it('should not trigger Use My Location when pressing enter in the input field', () => {

Check warning on line 234 in src/applications/facility-locator/tests/e2e/facilitySearchProgDisc.cypress.spec.js

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/facility-locator/tests/e2e/facilitySearchProgDisc.cypress.spec.js:234:3:Cypress E2E tests must include at least one axeCheck call. Documentation for adding checks and understanding errors can be found here: https://depo-platform-documentation.scrollhelp.site/developer-docs/A11y-Testing.1935409178.html
cy.visit('/find-locations');
typeInCityStateInput('27606');
// Wait for Use My Location to be triggered (it should not be)
Expand Down
Loading