Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nuget: PR Mentions Microsoft.NETFramework.ReferenceAssemblies Incorrectly #11556

Open
1 task done
Dor-bl opened this issue Feb 11, 2025 · 1 comment
Open
1 task done
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet T: bug 🐞 Something isn't working

Comments

@Dor-bl
Copy link

Dor-bl commented Feb 11, 2025

Is there an existing issue for this?

  • I have searched the existing issues

Package ecosystem

nuget

Package manager version

No response

Language version

No response

Manifest location and content before the Dependabot update

https://github.com/appium/dotnet-client/blob/main/test/integration/Appium.Net.Integration.Tests.csproj

dependabot.yml content

https://github.com/appium/dotnet-client/blob/main/.github/dependabot.yml

Updated dependency

Microsoft.NET.Test.Sdk from 17.12.0 to 17.13.0

What you expected to see, versus what you actually saw

The PR raised by Dependabot (#903) has the following issues:

The title should refer only to Microsoft.NET.Test.Sdk.
The title should include the version change in the correct format:
Expected: "Bump Microsoft.NET.Test.Sdk from 17.12.0 to 17.13.0 in /test/integration".
The description incorrectly states:
"Updates Microsoft.NETFramework.ReferenceAssemblies from 1.0.3 to 1.0.3 (no changes)"
This is misleading, as there is no actual change to Microsoft.NETFramework.ReferenceAssemblies.

Native package manager behavior

No response

Images of the diff or a link to the PR, issue, or logs

appium/dotnet-client#903

Smallest manifest that reproduces the issue

No response

@Dor-bl Dor-bl added the T: bug 🐞 Something isn't working label Feb 11, 2025
@Dor-bl Dor-bl changed the title PR Mentions Microsoft.NETFramework.ReferenceAssemblies Incorrectly nuget: PR Mentions Microsoft.NETFramework.ReferenceAssemblies Incorrectly Feb 15, 2025
@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label Feb 15, 2025
@brettfo
Copy link
Contributor

brettfo commented Feb 19, 2025

Thank you for filing the issue. This looks like a case where the dependabot common code couldn't handle multiple versions of the same dependency getting reported for an individual job.

The NuGet updater is currently being rewritten so this won't be an issue then, but we don't currently have an ETA on this new behavior. In the meantime you can safely ignore that part of the PR message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet T: bug 🐞 Something isn't working
Projects
Status: No status
Development

No branches or pull requests

2 participants