support for generating es6 imports and .d.ts files #1
Conversation
example/test.d.ts
Outdated
| @@ -0,0 +1,1013 @@ | |||
| declare namespace proto.jspb.test { | |||
There was a problem hiding this comment.
We don't want namespaces in the es6 output. I think we can just remove this and unindent the contents.
There was a problem hiding this comment.
Removed. For nested messages and enums, I still use export namespace Foo { class Bar ... } to represent Foo.Bar, which as I understand it should merge with the sibling export class Foo { }.
example/test.d.ts
Outdated
| @@ -0,0 +1,1013 @@ | |||
| declare namespace proto.jspb.test { | |||
| export class Empty extends jspb.Message { | |||
example/test.d.ts
Outdated
| declare namespace proto.jspb.test { | ||
| export class Empty extends jspb.Message { | ||
| constructor(data?: any[] | null); | ||
| toObject(includeInstance?: boolean): GlobalObject; |
There was a problem hiding this comment.
GlobalObject is a clutz specific hack for aliasing that we shouldn't need with es6.
Although I wonder if we need to do anything special if we're importing a message named Object. I guess if we use import * that won't be an issue.
There was a problem hiding this comment.
Replaced with { [key: string]: unknown } in return values. Currently also that for arguments, though as I type this I'm realizing in arguments it probably needs to be any for the values.
| // @ts-nocheck | ||
|
|
||
| import * as jspb from 'google-protobuf'; | ||
| var goog = jspb; |
There was a problem hiding this comment.
This probably wiill need to be something like import { goog } from 'closure-library/goog.js.
But that may be fine to figure out later.
Builds on protocolbuffers#150, adding:
libraryoption with ES6generate_dtsflag) and compatible (libraryoption set andimport_styleset toes6)Tested compilation of Derivita's omaha/base/ast.proto and inspecting the generated
omaha/base/ast_proto.jsandomaha/base/ast_proto.d.tsfiles.