Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add devfile 2.2 go sample to the public community registry #787

Closed
elsony opened this issue Mar 1, 2022 · 2 comments · Fixed by devfile/registry#105
Closed

Add devfile 2.2 go sample to the public community registry #787

elsony opened this issue Mar 1, 2022 · 2 comments · Fixed by devfile/registry#105
Assignees
Labels
area/registry Devfile registry for stacks and infrastructure

Comments

@elsony
Copy link
Contributor

elsony commented Mar 1, 2022

Which area/kind this issue is related to?
/area registry

Issue Description

Create a go sample similar to the existing devfile 2.2 samples in https://github.com/devfile/registry/blob/main/extraDevfileEntries.yaml.

Requirements:

  1. The contained devfile will be created based on the existing go devfile (https://github.com/devfile/registry/blob/main/stacks/go/devfile.yaml) and add the outer loop function to it.
  2. The sample application is based on the starter project: https://github.com/devfile-samples/devfile-stack-go.git but need to add the devfile, Dockerfile and deployment.yaml as part of the new sample repo
  3. Add the sample to the org https://github.com/devfile-samples
  4. Onboard to the public community registry by adding the new sample to the extraDevfileEntries.yaml
@openshift-ci openshift-ci bot added the area/registry Devfile registry for stacks and infrastructure label Mar 1, 2022
@yangcao77 yangcao77 assigned yangcao77 and unassigned maysunfaisal Apr 6, 2022
@yangcao77
Copy link
Contributor

The go sample is temporarily created under my own repo: https://github.com/yangcao77/go-sample
Will transfer to devfile-samples org after the sample has been approved.

@elsony
Copy link
Contributor Author

elsony commented Apr 14, 2022

The proposed repo looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/registry Devfile registry for stacks and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants