Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🍀 Proposal: New Plugin Development: GitLab CE #509

Closed
daniel-hutao opened this issue May 18, 2022 · 6 comments · Fixed by #692
Closed

🍀 Proposal: New Plugin Development: GitLab CE #509

daniel-hutao opened this issue May 18, 2022 · 6 comments · Fixed by #692
Assignees
Labels
enhancement New feature or request

Comments

@daniel-hutao
Copy link
Member

daniel-hutao commented May 18, 2022

What would you like to add? Why is this needed?

  • To support local deployment of gitlab-ce
  • Helm chart is preferred
  • Please give a simple design before you start coding

/cc @devstream-io/pmc

@daniel-hutao daniel-hutao added the enhancement New feature or request label May 18, 2022
@iyear
Copy link
Member

iyear commented May 18, 2022

Looks like a great idea, I'd like to work for it.

@daniel-hutao
Copy link
Member Author

/assign @iyear Happy coding!
Call me any time if you need.

@daniel-hutao
Copy link
Member Author

daniel-hutao commented May 28, 2022

@iyear @IronCore864

summary

I've spent most of the day researching how to deploy gitlab-ce, and have found some rather tricky issues.

1. gitlab-ce doesn't have an arm64 version or a darwin version of the image, so we can't run it locally. It only has the linux/amd64 version.

image

Related issues: Release arm64 docker images

2. If we use linux to test it, resource requirements:

image

@daniel-hutao
Copy link
Member Author

I have done some tests and have some suggestions for you @iyear:

  1. Deploy method: For simplicity, we start with docker support for the first version. Refer to the documentation here.
  2. Docker container image: use docker pull gitlab/gitlab-ce:rc
  3. OS support: linux only(we need to remind users in the documentation that the current plugin only supports linux deployment)
  4. domain: We give a default value, such as gitlab.change.me, and preserve the ability for user-defined domain names in the configuration file. e.g. hostname=gitlab.devstream.io or domain=gitlab.devstream.io
  5. https support: By default, this deploy method does not support https, but it doesn't matter, we can leave it to the next separate proposal to avoid making the first version too complicated. For more information on how to enable https, you can see here
  6. plugin name: Considering that the deployment of gitlab is likely that we will have support for vm and helm in the future, I suggest that the current plugin be named gitlab-ce-docker

/cc @IronCore864 @aFlyBird0 Looking forward to your suggestions.

@IronCore864
Copy link
Member

I have done some tests and have some suggestions for you @iyear:

1. `Deploy method`: For simplicity, we start with `docker` support for the first version. Refer to the [documentation here](https://docs.gitlab.com/ee/install/docker.html#install-gitlab-using-docker-engine).

2. `Docker container image`: use `docker pull gitlab/gitlab-ce:rc`

3. `OS support`: linux only(we need to remind users in the documentation that the current plugin only supports linux deployment)

4. `domain`: We give a default value, such as `gitlab.change.me`, and preserve the ability for user-defined domain names in the configuration file. e.g. `hostname=gitlab.devstream.io or domain=gitlab.devstream.io`

5. `https support`: By default, this deploy method does not support `https`, but it doesn't matter, we can leave it to the next separate proposal to avoid making the first version too complicated. For more information on how to enable https, you can see [here](https://docs.gitlab.com/omnibus/settings/nginx.html#enable-https)

6. `plugin name`: Considering that the deployment of gitlab is likely that we will have support for `vm` and `helm` in the future, I suggest that the current plugin be named `gitlab-ce-docker`

/cc @IronCore864 @aFlyBird0 Looking forward to your suggestions.

Great. Let's get started.

@aFlyBird0
Copy link
Member

Iyear has been very busy recently so I will take over his task. Thank you for your previous exploratory efforts. @iyear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants