Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to upstream changes in typer autocomplete interface. #123

Open
bckohan opened this issue Oct 5, 2024 · 1 comment
Open

Adapt to upstream changes in typer autocomplete interface. #123

bckohan opened this issue Oct 5, 2024 · 1 comment
Assignees
Labels
BREAKING This change will break downstream code. dependencies Pull requests that update a dependency file

Comments

@bckohan
Copy link
Member

bckohan commented Oct 5, 2024

shell_complete may be going away in future versions of Typer.

I am hoping my PR will be accepted which should minimize impacts to django-typer.

@bckohan bckohan added the dependencies Pull requests that update a dependency file label Oct 5, 2024
@bckohan bckohan self-assigned this Oct 5, 2024
@bckohan bckohan added the BREAKING This change will break downstream code. label Oct 5, 2024
@bckohan bckohan added this to the Version 3.0 milestone Nov 20, 2024
@bckohan
Copy link
Member Author

bckohan commented Feb 15, 2025

This should not hold up the 3.0 release any longer. It is unclear when upstream will merge my changes.

I've gone back and forth on this - but the breaking change upstream (shell_complete -> autocompletion) will not trigger a major version change on django-typer. We'll keep the dependencies tight and when this change happens we'll issue a feature release. This might break some projects that are using semantic versioning discipline on just django-typer but not also typer itself. It is what it is, I'm tired of waiting.

I think this is ok because the break will happen on a typer interface not a django-typer interface. Hopefully not many people are using the shell_complete features yet anyway...

@bckohan bckohan removed this from the Version 3.0 milestone Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING This change will break downstream code. dependencies Pull requests that update a dependency file
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant