Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect output for interpolated classnames #410

Closed
mlarcher opened this issue Dec 4, 2015 · 5 comments
Closed

incorrect output for interpolated classnames #410

mlarcher opened this issue Dec 4, 2015 · 5 comments

Comments

@mlarcher
Copy link

mlarcher commented Dec 4, 2015

I am opening this issue as a reminder, as the bug doesn't reside in gulp-sass but only affects it.
The problem occurs when there are constructs like

$someVar: '.className';
#{$someVar} {
    //...
  }

which results in

".className" {
    //...
}

Which won't be interpreted by the css parsers.
It's kind of difficult to spot at first, as it depends on your scss and can affect only a fe rules with no error output during compile.
Issue is coming from node-sass 3.4 and referenced at sass/node-sass#1217 which in turn leads to an issue in libsass referenced at sass/libsass#1624

Everything is fine when using node-sass 3.3.3 but the recent bump of gulp-sass to 2.1.0 forced the node-sass version to "^3.4.1", imposing this bug on all users.
I hope this helps others facing the same issue.

@xzyfer
Copy link
Collaborator

xzyfer commented Dec 10, 2015

I am unable to reproduce this with [email protected]. Can you confirm?

@mlarcher
Copy link
Author

Nope, the issue is still here in node-sass 3.4.2
Tracking in libsass is now on sass/libsass#1647

@falldowngoboone
Copy link

Apparently fixed in libsass 3.3.3? node-sass 3.4.2 is still using 3.3.2

@xzyfer
Copy link
Collaborator

xzyfer commented Feb 20, 2016

We're still ironing out some issues. You can get LibSass 3.3.3 using the beta.

npm install gulp-sass@beta

@xzyfer
Copy link
Collaborator

xzyfer commented May 10, 2016

This is fixed in v3.2.1.

@xzyfer xzyfer closed this as completed May 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants