Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad time for en-US culture #3

Closed
petronellius opened this issue May 16, 2017 · 1 comment
Closed

Bad time for en-US culture #3

petronellius opened this issue May 16, 2017 · 1 comment

Comments

@petronellius
Copy link
Contributor

JavaScript Date 00:26:00 with format 'hh:mm:ss tt' is bad formatted to '00:26:00 AM'.
I would expect to see '12:26:00 AM' instead.
Problem is in Date.prototype.__Format function when replacing hour part by numberPair((hour - 1) % 12 + 1). It may fixed by: hour % 12 || 12;

@dmester
Copy link
Owner

dmester commented May 17, 2017

Thanks for reporting this issue. It has now been fixed and the fix is included in release 1.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants