{docsify-updated} cannot show as expected in GitHub pages

[baicaihenxiao]

Bug Report

Steps to reproduce

I add this script to index.html so that {docsify-updated} can be shown at the bottom of every pags.

hook.beforeEach(function(content) {
  return content + '\n\n----\n\n' + '<p style="color: inherit; font-weight: normal; text-decoration: none; color: #828282;">Last updated <b>{docsify-updated}</b></p>';
});

What is current behaviour

It works well at my local computer, that is, the file updated at 04.22.2020 will show 04.22.2020, the file updated at 05.04 will show 05.04. However, when I made another commit while not modify these two files at 05.05.2020，and push the new commit to GitHub, all pages depolyed in GitHub pages show 05.05.2020 at bottom. Local docsify pages still work well and show 04.22 and 05.04.

What is the expected behaviour

{docsify-updated} shows the same behaviour at both the local and github pages environment

---

Maybe this problem is not created by docsify, because it works at my local computer. Is it true that github modify all the files even my new commit only contains one single file?

[sy-records]

Please create a reproducible sandbox

Or github repo address...

[jingqinglin]

Please create a reproducible sandbox

Or github repo address...

Hi, I have the same problem and I create a repo on gitee.

Repo address: https://gitee.com/JingqingLin/docsify-test
Gitee Pages address: https://jingqinglin.gitee.io/docsify-test

The first page was updated on 2020/06/02 20:42 and the second page was updated on 2020/06/02 20:45, but all pages was show 2020/06/02 20:45.

[sy-records]

Can you try to run on a server without a CDN? I think this is still a caching problem. @jingqinglin

[jingqinglin]

Can you try to run on a server without a CDN? I think this is still a caching problem. @jingqinglin

I put it on VPS, and the time is right.

If I deploy it on GitHub Pages, does {docsify-updated} show file modification time or show commit time?

[sy-records]

@jingqinglin You can try it use github pages.

gitee:

vps:

[jingqinglin]

I put it on GitHub Pages, {docsify-updated} shows commit time. But all files also show the same time. Is there any way to solve this problem?

[sy-records]

There doesn't seem to be a good solution. 😅
Get the last-modified value, but both the github page and the gitee page are cached release times, so they are consistent.
@anikethsaha Do you have any ideas?

[anikethsaha]

I forgot the context of this issue. I will check this soon.

[yzhang-gh]

I did a little search and found this, Last Modified Dates for GitHub Pages Jekyll Posts.

Basically, it uses GitHub API https://api.github.com/repos/{owner}/{repo}/commits?path={path} to get the metadata. I have checked and it does work as described (just type the url in the browser and you get a JSON array).

Now the problem is how to extract path from the parameter url here.

docsify/src/core/fetch/ajax.js

Line 61 in 75c72e9

updatedAt: xhr.getResponseHeader('last-modified'),

For me it is simply taking the string after yzhang-gh/{repo}/ path is simply your docs root + url. But I'm not sure whether we need to deal with other cases like custom domain.

[ghost]

Same problem. Any progress?

[ghost]

I have the same problem.
Every time I push new commits to github. {docsify-updated} in all pages is changed to the time of the latest push time.

but localhost the time is ok.

[sy-records]

Thank you @yzhang-gh for your comment #1157 (comment)

I provide some code for interested users to create a plugin.

Take docsify's repository as an example

  window.$docsify = {
    plugins: [
      function (hook, vm) {
        hook.beforeEach(function (html) {
          date_url = 'https://api.github.com/repos/docsifyjs/docsify/commits?per_page=1&path=' + vm.config.basePath + vm.route.file;
          fetch(date_url)
            .then((response) => {
              return response.json();
            })
            .then((commits) => {
              var modified = commits[0]['commit']['committer']['date'].slice(0, 10);
              document.getElementById('last-modified').textContent = "Last Modified: " + modified;
            });
          return (
            html +
            '\n\n----\n\n' +
            '<span id="last-modified"></span>'
          );
        });
      }
    ]
  };

[rxmapple]

HI ，this is a demo plugin:
https://github.com/rxmapple/docsify-last-modified