Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search is KO with IE11 #1526

Closed
StephaneG31 opened this issue Mar 8, 2021 · 8 comments · Fixed by #1527
Closed

Search is KO with IE11 #1526

StephaneG31 opened this issue Mar 8, 2021 · 8 comments · Fixed by #1527

Comments

@StephaneG31
Copy link

StephaneG31 commented Mar 8, 2021

When an IE11 user try to search in docsfy with IE11, there's an JS error and the search doesn't work.
image

@sy-records
Copy link
Member

Have you tried this?

image

<script src="//polyfill.io/v3/polyfill.min.js?features=String.prototype.normalize"></script>

see https://docsify.js.org/#/plugins?id=full-text-search

@StephaneG31
Copy link
Author

StephaneG31 commented Mar 8, 2021

The problem seems to be here :

$appName.classList.remove('hide');

In our case $appName is null. Is it possible to just add an if behind to test the presence of this object ?

@sy-records
Copy link
Member

Can you provide a reproducible sandbox?

@StephaneG31
Copy link
Author

@StephaneG31
Copy link
Author

If I remove the "n.classList.remove('hide')" it works but I think it's better to do an if check

@sy-records
Copy link
Member

Can you use this for testing?

<script src="https://docsify-preview-git-fork-sy-records-fix-1526-docsify-core.vercel.app/lib/docsify.js"></script>
<script src="https://docsify-preview-git-fork-sy-records-fix-1526-docsify-core.vercel.app/lib/plugins/search.js"></script>

@StephaneG31
Copy link
Author

Can you use this for testing?

<script src="https://docsify-preview-git-fork-sy-records-fix-1526-docsify-core.vercel.app/lib/docsify.js"></script>
<script src="https://docsify-preview-git-fork-sy-records-fix-1526-docsify-core.vercel.app/lib/plugins/search.js"></script>

I this it on my DEV ENV and it works!

@sy-records
Copy link
Member

Thank you for your feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants