Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrays of nested Widgets with conditional render logic are output in the wrong order #641

Closed
agubler opened this issue Jan 10, 2020 · 0 comments · Fixed by #642
Closed
Labels
area: core Core bug Something isn't working needs back-port The fix requires back porting to one or more previous major versions

Comments

@agubler
Copy link
Member

agubler commented Jan 10, 2020

Bug

In scenarios where there are multiple children of nested virtual widgets that conditionally render their output based on their properties the resulting DOM can be attached in the incorrect order. This only happens when the parent nested widgets invalidate in the sub tree and not within the same scheduled render (i.e. waiting for independent server side responses).

It seems to be caused by not being able to identify the top level dom node of the nested widget to insert before when rendering the DOM in from the first widget.

@agubler agubler added bug Something isn't working needs back-port The fix requires back porting to one or more previous major versions area: core Core labels Jan 10, 2020
@agubler agubler changed the title Children of nested Widgets with conditional render logic are output in the wrong order Arrays of nested Widgets with conditional render logic are output in the wrong order Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: core Core bug Something isn't working needs back-port The fix requires back porting to one or more previous major versions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant