Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right side of modeline cutoff when scrollbar disabled #2967

Closed
mustaqimM opened this issue Apr 25, 2020 · 2 comments
Closed

Right side of modeline cutoff when scrollbar disabled #2967

mustaqimM opened this issue Apr 25, 2020 · 2 comments
Labels
duplicate This issue or pull request already exists is:upstream Originates from outside the project and cannot be fully addressed here module:ui/modeline Pertains to Doom's :ui modeline module re:fonts Pertains to changing, using and loading fonts wontfix This will not be worked on workaround Contains a workaround, but no acceptable or final solution (yet)

Comments

@mustaqimM
Copy link

What did you expect to happen?
The modeline shouldn't be cut off

What actually happened?

Flycheck is cut off at the end
image.
On a whim, I tried enabling the scrollbar: toggle-scroll-bar
image

Steps to reproduce:

  1. Open file in Emacs with scrollbar disabled

System information:

emacs   version    26.3
        features   XPM JPEG TIFF GIF PNG RSVG SOUND DBUS GSETTINGS GLIB NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS XWIDGETS LCMS2
        build      Aug 29, 2019
        buildopts  (--with-x-toolkit=gtk3 --with-xwidgets --prefix=/usr --sysconfdir=/etc --sbindir=/usr/bin --bindir=/usr/bin --mandir=/usr/share/man --infodir=/usr/share/info --localstatedir=/var --with-file-notification=inotify --with-modules --with-jpeg --with-tiff --with-gif --with-png --with-xpm --with-rsvg --without-imagemagick --with-xml2 --with-gnutls --with-sound --with-m17n-flt --host=x86_64-unknown-linux-gnu --build=x86_64-unknown-linux-gnu 'CFLAGS=-fno-PIE -mtune=generic -O2 -pipe   -g' 'CPPFLAGS=   ' 'LDFLAGS=-no-pie -Wl,--as-needed    ')
        windowsys  x
        daemonp    daemon
doom    version    2.0.9
        build      HEAD -> develop, origin/develop, origin/HEAD 02374c69c 2020-04-22 02:13:51 -0400
        dir        ~/.config/doom/
system  type       gnu/linux
        config     x86_64-unknown-linux-gnu
        shell      /bin/zsh
        uname      Linux 5.4.34_1 #1 SMP PREEMPT Wed Apr 22 07:14:35 UTC 2020 x86_64
        path       (~/Library/Cloud/code/web/vuejs2/vue-cli/node_modules/.bin/ ~/.cargo/bin ~/.local/bin/sml/bin ~/.yarn/bin ~/.emacs.d/bin ~/.cargo/bin ~/.local/bin/sml/bin ~/.yarn/bin ~/.emacs.d/bin ~/.zinit/snippets/cht.sh ~/.zinit/plugins/zdharma---zsh-diff-so-fancy/bin ~/.zinit/plugins/junegunn---fzf-bin ~/.zinit/plugins/casey---intermodal ~/.zinit/plugins/sharkdp---bat/bat-v0.13.0-x86_64-unknown-linux-gnu ~/.zinit/plugins/imsnif---bandwhich ~/.zinit/plugins/karan---joe ~/.zinit/plugins/dylanaraps---pfetch ~/.zinit/plugins/pixelb---ps_mem ~/.zinit/plugins/direnv---direnv ~/.zinit/plugins/sei40kr---fast-alias-tips-bin ~/.zinit/polaris/bin ~/.cargo/bin ~/.local/bin/sml/bin ~/.yarn/bin ~/.emacs.d/bin /usr/local/bin /bin /usr/bin /usr/local/sbin /usr/sbin /sbin /usr/libexec/emacs/26.3/x86_64-unknown-linux-gnu/)
config  envfile    envvar-file
        elc-files  0
        modules    (:completion company ivy :ui doom doom-dashboard doom-quit hl-todo modeline nav-flash ophints (popup +all +defaults) tabs treemacs vc-gutter vi-tilde-fringe window-select workspaces :editor (evil +everywhere) file-templates fold multiple-cursors rotate-text snippets :emacs dired electric ibuffer vc :checkers syntax :tools editorconfig (eval +overlay) (lookup +docsets) lsp magit rgb :lang data emacs-lisp javascript latex lua markdown (org +dragndrop +present) plantuml python ruby rust sh (web +lsp) :config (default +bindings +smartparens))
        packages   ((flycheck-inline) (sml-mode) (vue-mode) (vimrc-mode))
        unpin      (n/a)
        elpa       (n/a)

@mustaqimM mustaqimM added the is:bug Something isn't working as intended label Apr 25, 2020
@hlissner
Copy link
Member

hlissner commented Apr 25, 2020

This is a duplicate of #1680, #278 and seagle0128/doom-modeline#334

I believe the consensus is: this is due to oversized icons, i.e. a font issue. Some possible solutions:

  1. Tweak all-the-icons-scale-factor (1.2 by default): (setq all-the-icons-scale-factor 1.1)

  2. Add some padding to the modeline definition:

    (after! doom-modeline
      (doom-modeline-def-modeline 'main
        '(bar matches buffer-info remote-host buffer-position parrot selection-info)
        '(misc-info minor-modes checker input-method buffer-encoding major-mode process vcs "  "))) ; <-- added padding here
  3. Use another font for the mode line (or a different :height) (source)

    (custom-set-faces!
      '(mode-line :family "Noto Sans" :height 0.9)
      '(mode-line-inactive :family "Noto Sans" :height 0.9))

Hope that helps!

@hlissner hlissner added module:ui/modeline Pertains to Doom's :ui modeline module duplicate This issue or pull request already exists is:upstream Originates from outside the project and cannot be fully addressed here re:fonts Pertains to changing, using and loading fonts workaround Contains a workaround, but no acceptable or final solution (yet) wontfix This will not be worked on and removed is:bug Something isn't working as intended labels Apr 25, 2020
@mustaqimM
Copy link
Author

That's perfect, thanks so much @hlissner

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate This issue or pull request already exists is:upstream Originates from outside the project and cannot be fully addressed here module:ui/modeline Pertains to Doom's :ui modeline module re:fonts Pertains to changing, using and loading fonts wontfix This will not be worked on workaround Contains a workaround, but no acceptable or final solution (yet)
Projects
None yet
Development

No branches or pull requests

2 participants