Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging images into single PDF #45

Closed
wants to merge 2 commits into from
Closed

Merging images into single PDF #45

wants to merge 2 commits into from

Conversation

pmensik
Copy link
Contributor

@pmensik pmensik commented Jul 11, 2018

Hello, I needed this functionality for the project I am working on so I thought I might share the idea. The usage is to merge any number of images provided as a vector to a single PDF file.

@dotemacs
Copy link
Owner

Thanks for this @pmensik I'll go over it properly a bit later

dotemacs pushed a commit that referenced this pull request Sep 6, 2020
The usage is to merge any number of images provided as a vector to a
single PDF file.

This change was added by Petr Mensik on 11th July 2018, here:
#45

But then the branch from which the PR was created, was deleted. So I
added these changes later, manually.
@dotemacs
Copy link
Owner

dotemacs commented Sep 6, 2020

Hello @pmensik

Thank you for creating this PR.

I went to merge it (and I tried to do it even earlier) but what stopped me was the fact that you've deleted the original branch the PR was created with. See:

image

So I added it now, manually, into this branch https://github.com/dotemacs/pdfboxing/tree/image-merge via this commit: 8ea9d3f

Thanks

dotemacs pushed a commit that referenced this pull request Sep 6, 2020
The usage is to merge any number of images provided as a vector to a
single PDF file.

This change was added by Petr Mensik on 11th July 2018, here:
#45

But then the branch from which the PR was created, was deleted. So I
added these changes later, manually.
@dotemacs
Copy link
Owner

dotemacs commented Sep 6, 2020

Merged it into master via the branch I mentioned above.

Thanks again

@dotemacs dotemacs closed this Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants