Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added byte array parsing to obtain-document function #58

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

cguckes
Copy link
Contributor

@cguckes cguckes commented Oct 29, 2020

That way you can use other sources than the file system for loading pdfs.

Description of your pull request

I needed the ability to load pdfs from other sources than files, in my case e-mails.

Why should it be considered?

It's a small change and it adds a lot of useful functionality.

Pull request checklist

Before submitting the PR make sure the following things have been done
(and denote this by checking the relevant checkboxes):

  • The code is consistent with Clojure style guide.
  • All code passes the linter (clj-kondo --lint src).
  • You've added tests (if possible) to cover your change(s).
  • All tests are passing.
  • The commits are consistent with the Git commit style guide.
  • You've updated the changelog (if adding/changing user-visible functionality).

Thanks!

@dotemacs
Copy link
Owner

dotemacs commented Nov 7, 2020

Hello @cguckes

Sorry that I didn't spot this before and thanks for your PR.

I've got a couple of pedantic suggestions, I hope you don't mind :)

If this is too much work/annoying, let me know, and I'll do it.

Thanks

@cguckes
Copy link
Contributor Author

cguckes commented Nov 9, 2020

@dotemacs, will do when I get the chance. Might be one or two days though...

@dotemacs
Copy link
Owner

dotemacs commented Nov 9, 2020 via email

This enables the use of in-memory pdfs from any source
instead of just files.
@cguckes
Copy link
Contributor Author

cguckes commented Nov 9, 2020

Ok, wasn't as hard as I thought... Ok now?

@dotemacs
Copy link
Owner

dotemacs commented Nov 9, 2020

Thanks great, thanks :)

@dotemacs dotemacs merged commit 4e9d388 into dotemacs:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants