CI polish #70
Merged
CI polish #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than using whatever is in the master, use a pinned version
As I'll use clojure-cli, these paths will be used
Adopt OpenJDK got moved to Eclipse Temurin, details: https://blog.adoptopenjdk.net/2021/08/goodbye-adoptopenjdk-hello-adoptium/
Trying to spread the test surface area, to have a better coverage
dotemacs
force-pushed
the
ci-polish
branch
2 times, most recently
from
ed79c48 to
08e57d3
Compare
By adding clj-kondo GitHub action, it ran the latest version of clj-kondo and caught this issue, which my old-er version of clj-kondo didn't. Self high-five!
Test fix for pdfboxing.html, the test wasn't really checking for equality
All were caught by linting test directory via clj-kondo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your pull request
CI polish & tweaks