Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your pull request
Previously
with-open
was used to open the PDF document that would be split. Which is fine if you're just thinking about closing the file after you've split it. But it doesn't seem very useful, because once you've split the file, you probably want to do something with it.I'm reverting this change introduced via
2ed5824 just to get some opinions in this issue: #46
Pull request checklist
Before submitting the PR make sure the following things have been done
(and denote this by checking the relevant checkboxes):
clj-kondo --lint src
).