Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for split-pdf #73

Merged
merged 2 commits into from
Mar 12, 2023
Merged

Fix for split-pdf #73

merged 2 commits into from
Mar 12, 2023

Conversation

dotemacs
Copy link
Owner

Description of your pull request

Previously with-open was used to open the PDF document that would be split. Which is fine if you're just thinking about closing the file after you've split it. But it doesn't seem very useful, because once you've split the file, you probably want to do something with it.

I'm reverting this change introduced via
2ed5824 just to get some opinions in this issue: #46

Pull request checklist

Before submitting the PR make sure the following things have been done
(and denote this by checking the relevant checkboxes):

  • The code is consistent with Clojure style guide.
  • All code passes the linter (clj-kondo --lint src).
  • You've added tests (if possible) to cover your change(s).
  • All tests are passing.
  • The commits are consistent with the Git commit style guide.
  • You've updated the changelog (if adding/changing user-visible functionality).

dotemacs and others added 2 commits March 11, 2023 13:33
Previously with-open was used to open the PDF document that would be
split. Which is fine if you're just thinking about closing the file
after you've split it. But it doesn't seem very useful, because once
you've split the file, you probably want to do something with it.

I'm reverting this change introduced via
2ed5824 just to get some opinions in
this issue: #46
@dotemacs dotemacs merged commit 39c75d7 into master Mar 12, 2023
@dotemacs dotemacs deleted the fix-for-split-pdf branch March 12, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant