Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure SignalR Service to the SignalR publish-to-Azure page #12744

Closed
bradygaster opened this issue Jun 7, 2019 · 10 comments · Fixed by #12764
Closed

Add Azure SignalR Service to the SignalR publish-to-Azure page #12744

bradygaster opened this issue Jun 7, 2019 · 10 comments · Fixed by #12764
Assignees
Labels

Comments

@bradygaster
Copy link
Member

Adding @guardrex and @danroth27 to this request. Dan and I were discussing the ways we could round out the docs on the upcoming Blazor and VS updates around SignalR and the Azure SignalR Service (ASRS). The Publish to Azure article should be updated to include screen shots of the SignalR provisioning suggestion in Visual Studio. Potentially show the resultant screen-shot in the Azure portal, too, inclusive of the App Service and ASRS instance.

@danroth27 danroth27 added the 3.0 label Jun 7, 2019
@bradygaster
Copy link
Member Author

bradygaster commented Jun 7, 2019

adding @vijayrkn to the discussion. @vijayrkn it'd be helpful to have some of the latest UI for this doc when they're available. I grabbed a few screen shots from existing testing manuals in case @guardrex can't replicate this (or improve upon these).

Updated publish start:
image

Updated provisioning:
image

SignalR Service drop-down presence:
image

Select/create ASRS instance:
image

@guardrex
Copy link
Collaborator

guardrex commented Jun 7, 2019

Let me verify the plan and ask a few ? ...

Publish an ASP.NET Core SignalR app to an Azure Web App

  1. The plan is to update the single example shown in the topic for a Blazor app with screenshots provided above that will apply to an upcoming round of Azure Portal and VS updates. We're not adding a separate Blazor example (for two examples), correct?
  2. There are some versioning issues to consider:
    • This is only SCD at this time because this is using 3.0, correct? Should this show FDD for 3.0? If so, should that be a follow-up issue for post-3.0 RTM given that there might be a slight delay on the Azure rollout of 3.0 at RTM and the fact that the guidance won't be useful between now and then unless this stays SCD during preview?
    • Since this is going to be a Blazor example, the whole topic must be versioned >=3.0. Is that correct? We won't have anything for 2.2 with a non-Blazor example?

@guardrex guardrex self-assigned this Jun 7, 2019
@guardrex guardrex added the Pri1 label Jun 7, 2019
@guardrex guardrex added this to the 2019 Q2 ends June 30 milestone Jun 7, 2019
@bradygaster
Copy link
Member Author

Close - IMO,

1: No, this would be just an update to this doc. That said, I don't mind your idea of a new doc at all. Whatever you do, do, I'd love to have copies of the publishing part in this doc.
2: After reading this one, I agree with your #1, that a Blazor-specific doc would be in order, as there'd be too many differences. Once the Blazor fire is no longer... uh... ablaze? - maybe we switch back and augment this doc, too.

But yes, a Blazor-specific doc would be better since there are enough variances.

@guardrex
Copy link
Collaborator

guardrex commented Jun 7, 2019

I left out a phrase that would've helped. When I typed "adding a separate Blazor example (for two examples)" ... I should've added "in this topic."

We can have one topic (this one) if you want ... we just version the content. The older content (current bits with new VS and Azure UI screenshots) for <3.0 and then add the new content versioned for >=3.0. It will end up as two large versioned blocks of text/images. Np ... it can be done if you want.

For the two-topic concept ... if you prefer going that way: This topic remains 2.2 (with updated screenshots). For a new Blazor-only 3.0 topic ...

  • Where do you want the physical file to reside (e.g., aspnetcore/host-and-deploy/blazor)? Where do you want this in the TOC (e.g., Blazor > Host and deploy > Azure SignalR Service)? @tdykstra
  • Looks like we'll need a 3.0-RTM-rollout-to-Azure issue to convert the Blazor example from SCD over to an FDD, correct?

@tdykstra
Copy link
Contributor

tdykstra commented Jun 7, 2019

Where do you want the physical file to reside (e.g., aspnetcore/host-and-deploy/blazor)? Where do you want this in the TOC (e.g., Blazor > Host and deploy > Azure SignalR Service)? @tdykstra

LGTM

While you're at it, you could move the SignalR Publish to App Service node to the Hosting and scaling node.

@guardrex
Copy link
Collaborator

guardrex commented Jun 7, 2019

While you're at it, you could move the SignalR Publish to App Service node to the Hosting and scaling node.

Sure thing.

@bradygaster Just need you (perhaps with @tdykstra) to make the final call ... this can go either way ...

  • Put the Blazor example, text, and screenshots in as updates to the existing Publish an ASP.NET Core SignalR app to an Azure Web App topic versioned for >=3.0, while the current 2.2 content in the topic remains there versioned for <3.0 with updated screenshots and text for VS and portal.
  • Go with the standalone Blazor version over in Blazor's Host and Deploy area (physical + TOC as planned above). In that case, the Publish an ASP.NET Core SignalR app to an Azure Web App topic gets updated screenshots/text and hangs there at 2.2 for now.

... and either way ... do I understand correctly that we'll need to sit on the PR for a bit until VS and Azure Portal updates land per the remarks on the issue?

Finally, I'll open up a follow-up issue to make the Blazor example an FDD after 3.0 rollout in Azure.

@tdykstra tdykstra added the PU label Jun 7, 2019
@danroth27
Copy link
Member

@guardrex @bradygaster This doc is about publishing apps that SignalR to Azure generally, so I don't think we should cover Blazor here. We have separate Blazor host & deploy topics for that (which could reference this doc). I think we should keep this doc generic for SignalR.

@guardrex
Copy link
Collaborator

guardrex commented Jun 8, 2019

Go with the standalone Blazor version over in Blazor's Host and Deploy area (physical + TOC as planned above). In that case, the Publish an ASP.NET Core SignalR app to an Azure Web App topic gets updated screenshots/text and hangs there at 2.2 for now.

Excellent ...

  • I'll use the screenshots from the issue to get the ball rolling.
  • Locations for Blazor version are:
    • Title: Publish an ASP.NET Core Blazor server-side app to Azure App Service
    • Physical: aspnetcore/host-and-deploy/blazor
    • TOC: Blazor > Host and deploy > Azure SignalR Service
    • UID: host-and-deploy/blazor/publish-to-azure-web-app (mirrors the naming of the SignalR one)
  • Blazor follow-up issue for 3.0 rollout in Azure to adopt FDD guidance.
  • It will go in as a draft PR given that I presume we'll need to confirm screens are correct when VS and Azure Portal UIs are released.
  • I'll also attempt to place the new screenshots (minus Blazor) into the SignalR TOC doc on the same PR.
  • I'll move the SignalR doc in the TOC to the Hosting and scaling node.

btw @tdykstra

  • I used "Host and deploy" while u were in Azure Land Docs because the guidance that we received from the localization cats was not to use gerunds in titles and headings unless they're part of a technology name. Do you want the same change that you made in the root TOC taken in the Blazor TOC on these updates?

    Host and deploy 👉 Hosting and deployment

  • "Publish to Azure" (for both topics) doesn't seem specific enough (especially in the Blazor case). In general, apps can be hosted by Azure App Service and Azure VMs. Blazor can also be hosted by Azure Storage. I recommend that the Azure SignalR overview doc (in the Azure docs) come out of the TOC so that our doc on the subject can be listed as "Azure SignalR Service," and the Azure doc is then cross-linked in our docs. Let's try it on the PR. I propose to use "Azure SignalR Service" for the Blazor doc, too. If it doesn't work out, we can modify my suggestion on the PR.

[EDIT] I'll remove the PU label ... I have the info that I need, and I'm going to work on this now (Saturday). I'll mark the PR with the PU label.

@guardrex guardrex removed the PU label Jun 8, 2019
@tdykstra
Copy link
Contributor

tdykstra commented Jun 8, 2019

Host and deploy 👉 Hosting and deployment

Yes, best to be consistent.

@guardrex
Copy link
Collaborator

guardrex commented Jun 8, 2019

I just discovered working thru these updates ...

I think we should keep this doc generic for SignalR.

We don't even need a Blazor version if this avoids screenshots showing naming (i.e., "Blazor").

Let's try it on the upcoming PR and see how it goes.

@Rick-Anderson Rick-Anderson moved this to Done in Blazor.Docs Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants