Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port additional runtime Helix SDK support to release/5.0 #7378

Closed
2 tasks
MattGal opened this issue May 11, 2021 · 1 comment
Closed
2 tasks

Port additional runtime Helix SDK support to release/5.0 #7378

MattGal opened this issue May 11, 2021 · 1 comment
Assignees

Comments

@MattGal
Copy link
Member

MattGal commented May 11, 2021

  • This issue is blocking
  • This issue is causing unreasonable pain

Should be a straightforward port, but there may be a follow up commit or two required.

Relevant issue for context: #7158

The meat of the change is just this:
https://github.com/dotnet/arcade/blob/main/src/Microsoft.DotNet.Helix/Sdk/tools/dotnet-cli/DotNetCli.targets#L26
... which should be a straight port, but I'm not just doing that because every time I say that I get surprised:

@ilyas1974 since this helps mitigate the azureedge.net SSL issue for ASP, I'm dumping it straight into FR.

@riarenas
Copy link
Member

The change made it through arcade-validation and is now available in the ".net 5 eng" channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants