Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameterize TFM from net5.0 -> to $(TargetTfm) #22737

Closed
dougbu opened this issue Jun 9, 2020 · 7 comments
Closed

Parameterize TFM from net5.0 -> to $(TargetTfm) #22737

dougbu opened this issue Jun 9, 2020 · 7 comments
Labels
affected-few This issue impacts only small number of customers area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework enhancement This issue represents an ask for new feature or an enhancement to an existing one severity-minor This label is used by an internal tool

Comments

@dougbu
Copy link
Member

dougbu commented Jun 9, 2020

  • so that we don't have to change 100s of files and we can work concurrently on net6.0
@dougbu
Copy link
Member Author

dougbu commented Jun 9, 2020

Issue here it the number of hard-coded TFMs in *.cs and *.nuget and so on. Might even be able to reduce what's hard-coded in the project template files.

@javiercn javiercn added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jun 10, 2020
@javiercn javiercn added this to the 5.0.0-preview8 milestone Jun 23, 2020
@pranavkm pranavkm modified the milestones: 5.0.0-preview8, 5.0.0-rc1 Aug 17, 2020
@pranavkm
Copy link
Contributor

@dougbu is this still a thing now that we have a 6.0 branch?

@dougbu
Copy link
Member Author

dougbu commented Aug 17, 2020

This isn't related to how we're branded or branching, it's about our default TFM and how many times it appears in our source code.

Bottom line, we'll do this while switching to target net6.0.

@Pilchie
Copy link
Member

Pilchie commented Sep 2, 2020

@dougbu should we update the milestone here?

@dougbu dougbu modified the milestones: 5.0.0-rc1, 5.0.0-rc2, 6.0.0-alpha1 Sep 2, 2020
@dougbu
Copy link
Member Author

dougbu commented Sep 2, 2020

Yes, it's not mandatory for 5.0 and definitely not for RC1. Moved this to 6.0 because that's where we need to deal with net6.0.

@halter73 halter73 mentioned this issue Oct 12, 2020
Merged
@dougbu
Copy link
Member Author

dougbu commented Oct 12, 2020

@halter73 please include this issue in your hand-off notes to @TanayParikh

@wtgodbe wtgodbe added affected-few This issue impacts only small number of customers enhancement This issue represents an ask for new feature or an enhancement to an existing one severity-minor This label is used by an internal tool labels Nov 12, 2020 — with ASP.NET Core Issue Ranking
@dougbu dougbu modified the milestones: 6.0-preview1, 6.0-preview2 Feb 11, 2021
@pranavkm pranavkm modified the milestones: 6.0-preview2, 6.0-preview4 Mar 19, 2021
@pranavkm pranavkm modified the milestones: 6.0-preview4, 6.0-preview5 May 13, 2021
@BrennanConroy BrennanConroy removed this from the 6.0-preview5 milestone Jul 14, 2021
@wtgodbe
Copy link
Member

wtgodbe commented Nov 19, 2024

This was done a while ago

@wtgodbe wtgodbe closed this as completed Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affected-few This issue impacts only small number of customers area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework enhancement This issue represents an ask for new feature or an enhancement to an existing one severity-minor This label is used by an internal tool
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@pranavkm @Pilchie @dougbu @javiercn @BrennanConroy @wtgodbe and others