System.Security.Claims.PrincipalExtensions.FindFirstValue should return nullable value

[leotsarev]

Is your feature request related to a problem? Please describe.

        //
        // Summary:
        //     Returns the value for the first claim of the specified type, otherwise null if
        //     the claim is not present.
        //
        // Parameters:
        //   principal:
        //     The System.Security.Claims.ClaimsPrincipal instance this method extends.
        //
        //   claimType:
        //     The claim type whose first value should be returned.
        //
        // Returns:
        //     The value of the first instance of the specified claim type, or null if the claim
        //     is not present.
        public static string FindFirstValue(this ClaimsPrincipal principal, string claimType);

Describe the solution you'd like

It should be public static string? FindFirstValue(this ClaimsPrincipal principal, string claimType);

[blowdart]

Why do you believe it should be nullable? What claim are you using that has a null value? As claims are serialised as strings it's generally just string.empty

[leotsarev]

@blowdart because it literally says so in XML doc: or null if the claim is not present. FindFirstValue source code also consistent with this.

[blowdart]

Ah got it. OK that makes sense @HaoK a quick one for you

[ghost]

Thanks for contacting us.

We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

[HaoK]

nullable isn't enabled for identity yet, so this is true in more than just this method

[leotsarev]

@HaoK I didn't found tracking issue for "enable nullability for Identity"

[HaoK]

#27389 is one of the meta work items, we have some nullable support but its not fully implemented everywhere yet

[HaoK]

Closing as this is tracked by #27389