Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider SignalR Pull Model / Streaming for JavaScript and Java client #33859

Open
TanayParikh opened this issue Jun 25, 2021 · 2 comments
Open
Labels
area-signalr Includes: SignalR clients and servers Blazor ♥ SignalR This issue is related to the experience of Signal R and Blazor working together enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-blazor-jsinterop This issue is related to JSInterop in Blazor Priority:3 Work that is nice to have
Milestone

Comments

@TanayParikh
Copy link
Contributor

TanayParikh commented Jun 25, 2021

As a part of #30289 / #33491 we didn't leverage SignalR's native streaming capability as we wanted to delay sending additional data chunks until the ones sent had been consumed by the server. Without this, the client could queue the entire stream at once (via subject.next(nextData)) thereby blocking interactivity till the stream was transferred. This would in turn present a breaking change for certain functionality like file uploads. Instead we took a send/invoke based approach where we send X chunks, and then invoke every X+1 chunks to get a "heartbeat" for the stream, and allow other requests to interrupt the transfer.

@TanayParikh TanayParikh added area-signalr Includes: SignalR clients and servers Blazor ♥ SignalR This issue is related to the experience of Signal R and Blazor working together feature-blazor-jsinterop This issue is related to JSInterop in Blazor labels Jun 25, 2021
@davidfowl davidfowl changed the title Consider SignalR Pull Model / Streaming Consider SignalR Pull Model / Streaming for JavaScript client Jun 25, 2021
@davidfowl davidfowl changed the title Consider SignalR Pull Model / Streaming for JavaScript client Consider SignalR Pull Model / Streaming for JavaScript and Java client Jun 25, 2021
@BrennanConroy BrennanConroy added the enhancement This issue represents an ask for new feature or an enhancement to an existing one label Jun 28, 2021
@BrennanConroy BrennanConroy added this to the Backlog milestone Jun 28, 2021
@ghost
Copy link

ghost commented Jun 28, 2021

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@ghost
Copy link

ghost commented Jan 13, 2022

Thanks for contacting us.

We're moving this issue to the .NET 7 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-signalr Includes: SignalR clients and servers Blazor ♥ SignalR This issue is related to the experience of Signal R and Blazor working together enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-blazor-jsinterop This issue is related to JSInterop in Blazor Priority:3 Work that is nice to have
Projects
None yet
Development

No branches or pull requests

4 participants