Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AOT] Explore Alternatives to MakeGenericType/MakeGenericMethod For Web UI #45795

Closed
1 of 6 tasks
Nick-Stanton opened this issue Dec 28, 2022 · 4 comments
Closed
1 of 6 tasks
Labels
area-blazor Includes: Blazor, Razor Components enhancement This issue represents an ask for new feature or an enhancement to an existing one ✔️ Resolution: Duplicate Resolved as a duplicate of another issue NativeAOT Pillar: Technical Debt Status: Resolved

Comments

@Nick-Stanton
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

There are multiple uses of MakeGenericType() and MakeGenericMethod() throughout the Microsoft.AspNetCore.Components and Microsoft.JSInterop projects that make them unsafe for AOT scenarios. Initially it was believed that the warnings surrounding these would be suppressible since these projects are already trim-safe, but there are multiple places where we cannot guarantee the safety of the suppression.

During review of #45580, there was the suggestion of exploring a non-dynamic code fallback such as here. Further investigation found that the performance degradation would make this a poor approach when dealing with Blazor.

Describe the solution you'd like

The below uses of MakeGenericMethod() and MakeGenericType() need to either have an AOT-safe fallback or a refactor (e.g. source generation) which allows these type-generic methods to not require JIT compilation.

Microsoft.AspNetCore.Components

Microsoft.JSInterop

Additional context

Linked to #45578, the other part of Web UI's remaining work in #45473.

AOT analysis for these projects is already turned off by #45604.

@Nick-Stanton Nick-Stanton added enhancement This issue represents an ask for new feature or an enhancement to an existing one area-blazor Includes: Blazor, Razor Components labels Dec 28, 2022
@Nick-Stanton Nick-Stanton added this to the .NET 8 Planning milestone Dec 28, 2022
@ghost
Copy link

ghost commented Dec 28, 2022

Thanks for contacting us.

We're moving this issue to the .NET 8 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@ghost
Copy link

ghost commented Jun 29, 2023

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@ghost
Copy link

ghost commented Dec 13, 2023

Thanks for contacting us.

We're moving this issue to the .NET 9 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@mkArtakMSFT
Copy link
Member

We'll address this as part of #51598

@mkArtakMSFT mkArtakMSFT closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2024
@mkArtakMSFT mkArtakMSFT added the ✔️ Resolution: Duplicate Resolved as a duplicate of another issue label Jan 9, 2024
@ghost ghost added the Status: Resolved label Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components enhancement This issue represents an ask for new feature or an enhancement to an existing one ✔️ Resolution: Duplicate Resolved as a duplicate of another issue NativeAOT Pillar: Technical Debt Status: Resolved
Projects
None yet
Development

No branches or pull requests

2 participants