Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

[master] Update dependencies from dotnet/corefx #27431

Merged
merged 4 commits into from
Oct 26, 2019
Merged

[master] Update dependencies from dotnet/corefx #27431

merged 4 commits into from
Oct 26, 2019

Conversation

dotnet-maestro[bot]
Copy link

@dotnet-maestro dotnet-maestro bot commented Oct 25, 2019 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/corefx

  • Build: 20191025.6
  • Date Produced: 10/26/2019 7:24 AM
  • Commit: 8245ee1e8f6063ccc7a3a60cafe821d29e85b02f
  • Branch: refs/heads/master
  • Updates:
    • Microsoft.NETCore.Platforms -> 5.0.0-alpha.1.19525.6
    • Microsoft.Private.CoreFx.NETCoreApp -> 5.0.0-alpha.1.19525.6

@dotnet-maestro
Update dependencies from https://github.com/dotnet/corefx build 20191…
89c25b1 
…024.13

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19524.13
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19524.13
@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented Oct 25, 2019 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: coreclr-ci
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@tannergooding
Copy link
Member

tannergooding commented Oct 25, 2019 •
edited
Loading

CC. @VSadov

Failure in Run Test Pri0 CoreFX Linux x64 Checked is:

Assert failure(PID 13146 [0x0000335a], Thread: 13258 [0x33ca]): Assertion failed 'retExpr->gtOper == GT_RETURN' in 'System.Diagnostics.Tests.StopwatchTests:GetTimestamp()' (IL size 26)

    File: /__w/1/s/src/jit/morph.cpp Line: 18653
    Image: /home/helixbot/work/52008b79-f42e-45e8-afe7-cb6dc9c0e537/Payload/dotnet

Might just be CoreFX tests vs CoreCLR sources being out of sync? Edit: No, I don't think that could be it, since the type forwards don't exist and so the test should still resolve to the impl in S.R.Extensions

@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented Oct 25, 2019 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: coreclr-ci (Run Test Pri0 R2R Linux x64 checked), coreclr-ci (Run Test Pri0 CoreFX Linux x64 checked), coreclr-ci
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/corefx build 20191…
62ec100 
…024.14

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19524.14
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19524.14
@VSadov
Copy link
Member

VSadov commented Oct 25, 2019

Fx version will be removed. I was waiting for mirror bot to push a PR with coreclr changes to fx

@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented Oct 25, 2019 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: coreclr-ci (Run Test Pri0 R2R Linux x64 checked), coreclr-ci (Run Test Pri0 CoreFX Linux x64 checked), coreclr-ci
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@tannergooding
Copy link
Member

tannergooding commented Oct 25, 2019 •
edited
Loading

Fx version will be removed. I was waiting for mirror bot to push a PR with coreclr changes to fx

Right, but will that fix the issue? The type forwards don't exist yet and so these APIs should still be resolving to the implementation in S.R.Extensions.dll; in which case nothing has changed on the CoreFX side...

Actually, looking at the delta of changes coming in: https://github.com/dotnet/corefx/compare/be22fd85b2ceb377de87e6bda006f819569fec3a...0954a975f972546314bd3ac4eb6e0a6380a85701?expand=1, this is the first change where QPC (which is what the failing test is covering) is annotated with SupressGCTransition. CC. @AaronRobinsonMSFT

Edit: Here is the list of changes not currently in CoreFX: https://github.com/dotnet/coreclr/compare/7bc2158ff0a26ca639503b327ba79bd21183fd58...master?expand=1

@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented Oct 25, 2019 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: coreclr-ci (Run Test Pri0 CoreFX Linux x64 checked), coreclr-ci
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/corefx build 20191…
3c6c9c8 
…025.6

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19525.6
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19525.6
@tannergooding
Copy link
Member

tannergooding commented Oct 26, 2019 •
edited
Loading

Failure still repros after picking up dotnet/corefx#42121 (which removed the FX version of the stopwatch functions).

I'm testing locally to see if I can repro and confirm the issue.

@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented Oct 26, 2019 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: coreclr-ci (Run Test Pri0 CoreFX Linux x64 checked), coreclr-ci
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@VSadov
Copy link
Member

VSadov commented Oct 26, 2019

Also - why is it a problem only on Linux?

@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented Oct 26, 2019 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: coreclr-ci (Run Test Pri0 CoreFX Linux x64 checked), coreclr-ci
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@tannergooding
Copy link
Member

I managed to repro. It only repros with COMPlus_TieredCompilation=0

@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented Oct 26, 2019 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: coreclr-ci (Run Test Pri0 CoreFX Linux x64 checked), coreclr-ci
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@tannergooding
Copy link
Member

Also confirmed that removing SuppressGCTransition from Interop.Sys.GetTimestamp (https://github.com/dotnet/coreclr/blob/master/src/System.Private.CoreLib/shared/Interop/Unix/System.Native/Interop.GetTimestamp.cs) resolves the issue.

CC. @AaronRobinsonMSFT, @jkotas

@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented Oct 26, 2019 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: coreclr-ci (Run Test Pri0 CoreFX Linux x64 checked), coreclr-ci
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@VSadov
Copy link
Member

VSadov commented Oct 26, 2019

I think we should remove SuppressGCTransition from Interop.Sys.GetTimestamp to unblock this and enter a bug to track.

@tannergooding - can you push the change to this PR?

@AaronRobinsonMSFT
Copy link
Member

Looks like the following assert is firing for the Interop.Sys.GetTimestamp case. I can look into this today. I would assume this isn't a huge issue just an overly aggressive assert since I had to modify several during the work.

Assert failure(PID 29805 [0x0000746d], Thread: 29824 [0x7480]): Assertion failed 'retExpr->gtOper == GT_RETURN' in 'System.Diagnostics.Tests.StopwatchTests:GetTimestamp()' (IL size 26)

    File: /__w/2/s/src/jit/morph.cpp Line: 18653
    Image: /home/helixbot/work/409fcbf4-4e6f-4b59-a1b8-38c6da3609f0/Payload/dotnet

@jkotas
Copy link
Member

jkotas commented Oct 26, 2019

Added workaround and filled https://github.com/dotnet/coreclr/issues/27465

@tannergooding
Copy link
Member

Was going to, but looks like Jan got to it first 😄

@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented Oct 26, 2019 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❓ Waiting on checks: coreclr-ci (Run Test Pri0 R2R Windows_NT x86 checked), coreclr-ci (Run Test Pri0 Windows_NT x86 checked), coreclr-ci
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@tannergooding tannergooding merged commit cfdec44 into master Oct 26, 2019
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/corefx that referenced this pull request Oct 26, 2019
@dotnet-maestro @dotnet-bot
Update dependencies from dotnet/corefx (dotnet/coreclr#27431)
305505c 
* Update dependencies from https://github.com/dotnet/corefx build 20191024.13

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19524.13
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19524.13

* Update dependencies from https://github.com/dotnet/corefx build 20191024.14

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19524.14
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19524.14

* Update dependencies from https://github.com/dotnet/corefx build 20191025.6

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19525.6
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19525.6

* Workaround https://github.com/dotnet/coreclr/issues/27465

Signed-off-by: dotnet-bot <[email protected]>
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/corert that referenced this pull request Oct 26, 2019
@dotnet-maestro @dotnet-bot
Update dependencies from dotnet/corefx (dotnet/coreclr#27431)
1bd36da 
* Update dependencies from https://github.com/dotnet/corefx build 20191024.13

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19524.13
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19524.13

* Update dependencies from https://github.com/dotnet/corefx build 20191024.14

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19524.14
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19524.14

* Update dependencies from https://github.com/dotnet/corefx build 20191025.6

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19525.6
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19525.6

* Workaround https://github.com/dotnet/coreclr/issues/27465

Signed-off-by: dotnet-bot <[email protected]>
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/mono that referenced this pull request Oct 26, 2019
@dotnet-maestro @dotnet-bot
Update dependencies from dotnet/corefx (dotnet/coreclr#27431)
3bace5d 
* Update dependencies from https://github.com/dotnet/corefx build 20191024.13

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19524.13
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19524.13

* Update dependencies from https://github.com/dotnet/corefx build 20191024.14

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19524.14
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19524.14

* Update dependencies from https://github.com/dotnet/corefx build 20191025.6

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19525.6
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19525.6

* Workaround https://github.com/dotnet/coreclr/issues/27465

Signed-off-by: dotnet-bot <[email protected]>
stephentoub pushed a commit to dotnet/corefx that referenced this pull request Oct 26, 2019
@dotnet-maestro @stephentoub
Update dependencies from dotnet/corefx (dotnet/coreclr#27431)
0d0336c 
* Update dependencies from https://github.com/dotnet/corefx build 20191024.13

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19524.13
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19524.13

* Update dependencies from https://github.com/dotnet/corefx build 20191024.14

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19524.14
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19524.14

* Update dependencies from https://github.com/dotnet/corefx build 20191025.6

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19525.6
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19525.6

* Workaround https://github.com/dotnet/coreclr/issues/27465

Signed-off-by: dotnet-bot <[email protected]>
jkotas pushed a commit to dotnet/corert that referenced this pull request Oct 26, 2019
@dotnet-maestro @jkotas
Update dependencies from dotnet/corefx (dotnet/coreclr#27431)
896a4fb 
* Update dependencies from https://github.com/dotnet/corefx build 20191024.13

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19524.13
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19524.13

* Update dependencies from https://github.com/dotnet/corefx build 20191024.14

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19524.14
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19524.14

* Update dependencies from https://github.com/dotnet/corefx build 20191025.6

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19525.6
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19525.6

* Workaround https://github.com/dotnet/coreclr/issues/27465

Signed-off-by: dotnet-bot <[email protected]>
marek-safar pushed a commit to mono/mono that referenced this pull request Oct 27, 2019
@dotnet-maestro @marek-safar
Update dependencies from dotnet/corefx (dotnet/coreclr#27431)
6f04054 
* Update dependencies from https://github.com/dotnet/corefx build 20191024.13

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19524.13
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19524.13

* Update dependencies from https://github.com/dotnet/corefx build 20191024.14

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19524.14
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19524.14

* Update dependencies from https://github.com/dotnet/corefx build 20191025.6

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19525.6
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19525.6

* Workaround https://github.com/dotnet/coreclr/issues/27465

Signed-off-by: dotnet-bot <[email protected]>
@jkotas jkotas deleted the darc-master-c7373552-a7b4-45ca-9db5-e22e121ee4ff branch October 27, 2019 21:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tannergooding @VSadov @AaronRobinsonMSFT @jkotas