Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrations: Track Parent Migrations #1911

Closed
bricelam opened this issue Mar 26, 2015 · 9 comments
Closed

Migrations: Track Parent Migrations #1911

bricelam opened this issue Mar 26, 2015 · 9 comments
Assignees

Comments

@bricelam
Copy link
Contributor

This would allow us to better detect conflicts, but we would also need some way to merge.

@rowanmiller
Copy link
Contributor

@bricelam do you think we still need this now that we have model snapshot?

@bricelam
Copy link
Contributor Author

bricelam commented Dec 5, 2015

It would help us detect conflicts. The snapshot in the migration can still get into a bad state. We use that snapshot for column types currently. We'll use it for rebuilds in the future.

@bricelam
Copy link
Contributor Author

bricelam commented Dec 5, 2015

So, it will help us do better, but maybe what we have is "good enough".

@bricelam
Copy link
Contributor Author

bricelam commented Dec 5, 2015

Although doing a rebuild but missing a column because it was added (but not synced) before you generated your migration would be a pain to debug (and maybe even notice).

@rowanmiller
Copy link
Contributor

Ah yeah... rebuilds from the snapshot... didn't think of that. Is this trivial to just add now, or do you think it should go on backlog?

@bricelam
Copy link
Contributor Author

bricelam commented Dec 9, 2015

It's trivial to add the pointer, but it might end up being YAGNI since we won't actually do anything with it now.

@bricelam
Copy link
Contributor Author

bricelam commented Dec 9, 2015

I don't think it's a breaking change to add later either since we can just infer the parent migration from the order

@rowanmiller rowanmiller modified the milestones: 1.0.0, 1.0.1 May 13, 2016
@rowanmiller rowanmiller removed this from the 1.1.0 milestone Jul 1, 2016
@rowanmiller
Copy link
Contributor

We can do this if we find a feature that would use it

@bricelam
Copy link
Contributor Author

bricelam commented Jul 2, 2016

My thoughts exactly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants