From ae6560976d7a8d20ae18bed96e33ae6a2fc5c754 Mon Sep 17 00:00:00 2001 From: Jonathan Peppers Date: Tue, 20 Feb 2024 13:13:30 -0600 Subject: [PATCH] [Java.Interop] restore `IL2035` suppression (#1195) c6e38933 introduced build warning(s) in Android projects: external/Java.Interop/src/Java.Interop/Java.Interop/JniRuntime.JniMarshalMemberBuilder.cs(33,4): warning IL2035: Java.Interop.JniRuntime.SetMarshalMemberBuilder(JniRuntime.CreationOptions): Unresolved assembly 'Java.Interop.Export' in 'DynamicDependencyAttribute'. external/Java.Interop/src/Java.Interop/Java.Interop/JniRuntime.JniMarshalMemberBuilder.cs(33,4): warning IL2035: Java.Interop.JniRuntime.SetMarshalMemberBuilder(JniRuntime.CreationOptions): Unresolved assembly 'Java.Interop.Export' in 'DynamicDependencyAttribute'. external/Java.Interop/src/Java.Interop/Java.Interop/JniRuntime.JniMarshalMemberBuilder.cs(33,4): warning IL2035: Java.Interop.JniRuntime.SetMarshalMemberBuilder(JniRuntime.CreationOptions): Unresolved assembly 'Java.Interop.Export' in 'DynamicDependencyAttribute'. external/Java.Interop/src/Java.Interop/Java.Interop/JniRuntime.JniMarshalMemberBuilder.cs(33,4): warning IL2035: Java.Interop.JniRuntime.SetMarshalMemberBuilder(JniRuntime.CreationOptions): Unresolved assembly 'Java.Interop.Export' in 'DynamicDependencyAttribute'. One of these appear per-RID. Partially revert c6e38933 to restore the IL2035 suppression that was removed. --- .../Java.Interop/JniRuntime.JniMarshalMemberBuilder.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Java.Interop/Java.Interop/JniRuntime.JniMarshalMemberBuilder.cs b/src/Java.Interop/Java.Interop/JniRuntime.JniMarshalMemberBuilder.cs index ea0467a29..77be210f0 100644 --- a/src/Java.Interop/Java.Interop/JniRuntime.JniMarshalMemberBuilder.cs +++ b/src/Java.Interop/Java.Interop/JniRuntime.JniMarshalMemberBuilder.cs @@ -28,6 +28,7 @@ public JniMarshalMemberBuilder MarshalMemberBuilder { } [DynamicDependency (DynamicallyAccessedMemberTypes.PublicParameterlessConstructor, "Java.Interop.MarshalMemberBuilder", "Java.Interop.Export")] + [UnconditionalSuppressMessage ("Trimming", "IL2035", Justification = "Java.Interop.Export.dll is not always present.")] partial void SetMarshalMemberBuilder (CreationOptions options) { if (!options.UseMarshalMemberBuilder) {