-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect the new UnconditionalSuppressMessageAttribute #1147
Comments
There are several aspects of this which can be done in stages:
Performance considerations: When a warning is suppressed it should be fast - linker should not spend my time finding and suppressing the warning. This is expected to be a relatively common case (likely used inside our frameworks so all apps are affected). This means that finding and matching the suppression attributes must be fast and when a warning is suppressed linker should not spend any time computing the details of the warning (specifically constructing the warning message). |
Note that the format of the |
We might be able to steal the parser for Target from Roslyn. Roslyn team typically spends a lot of time thinking about corner cases, so it might be beneficial to at least look at it, if not fork it into our repo. |
@eerhardt pointed me to some folks who have more context on the |
When code wants to suppress a linker warning, for example when the author is certain it is safe, they can add an
UnconditionalSuppressMessageAttribute
. We should support this new attribute in the linker.See dotnet/runtime#35339 for the discussion.
The text was updated successfully, but these errors were encountered: