[Android] Shell Navigation to a page without a Tabbar #27779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
kubaflo
added
platform/android 🤖
area-controls-shell
kubaflo
changed the title
kubaflo
changed the title
jsuarezruiz
requested changes
Feb 13, 2025
| @@ -77,6 +77,9 @@ public override AView OnCreateView(LayoutInflater inflater, ViewGroup container, | |||
| _navigationArea = PlatformInterop.CreateNavigationBarArea(context, _outerLayout); | |||
| _bottomView = PlatformInterop.CreateNavigationBar(context, Resource.Attribute.bottomNavigationViewStyle, _outerLayout, this); | |||
|
|
|||
| //This layout chage happens when fragment manager has completed a transaction | |||
| _navigationArea.LayoutChange += (s, e) => UpdateTabBarVisibility(); | |||
There was a problem hiding this comment.
Subscribe to the event when creating the View but also unsubscribe when destroying it.
kubaflo
force-pushed
the
android-shell-tabbar-navigation
branch
from
0c3e731 to
38ce93c
Compare
What could we test in here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Fixed
Fixes #27980
Screen.Recording.2025-02-13.at.15.25.35.mov
Screen.Recording.2025-02-13.at.15.21.54.mov